Pr47 #25
Merged
Pr47 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabaronett
reviewed
Apr 14, 2020
| * @param rebx pointer to the REBOUNDx extras instance. | ||
| * @param Nvalues Length of times and values arrays (must be equal for both). | ||
| * @param times Array of times at which the corresponding values are supplied. | ||
| * @param times Array of values at each corresponding time. |
There was a problem hiding this comment.
param name should be values here
sabaronett
approved these changes
Apr 14, 2020
This was referenced Apr 14, 2020
sabaronett
added a commit
that referenced
this pull request
Dec 3, 2023
Pr47 Former-commit-id: 0cbba9d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Stanley,
I've updated a bit of the discussion in ParameterInterpolation.ipynb and have added a header to interpolation.c so that it shows up in the documentation. If you could take a look at those and merge this in your branch together with any changes you want to make, we can merge this into master!
I've also taken the opportunity to make some updates to the documentation that had fallen behind. Thank you SO much for all your great work on this!