Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lacks PHP v8.1 compatibility #338

Closed
dleffler opened this issue Sep 8, 2021 · 6 comments
Closed

Lacks PHP v8.1 compatibility #338

dleffler opened this issue Sep 8, 2021 · 6 comments

Comments

@dleffler
Copy link

dleffler commented Sep 8, 2021

PHP v8.1 (currently a release candidate) deprecates several parameter types and throws warnings such as Deprecated: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in PHP-CSS-Parser\lib\Sabberworm\CSS\Parsing\ParserState.php on line 285
@oliverklee
Copy link
Contributor

@dleffler We currently unfortunately cannot run the unit tests with PHP 8.1 yet. Would you be willing to list all problems you encounter with PHP 8.1? Then I can take a look. Thanks!

@TimWolla TimWolla mentioned this issue Oct 28, 2021
Merged
TimWolla added a commit to WoltLab/PHP-CSS-Parser that referenced this issue Oct 29, 2021
@TimWolla
Fix PHP 8.1 compatibility in ParserState::strsplit()
2c397c3 
> Error Message: preg_split(): Passing null to parameter MyIntervals#3 ($limit) of type int is deprecated

see MyIntervals#338

(cherry picked from commit 84b3ba7)
@xmav
Copy link

xmav commented Dec 4, 2021 •
edited
Loading

Hi @oliverklee !
Since this PR is merged can we expect new release? (to be used with pelago/emogrifier)

@sabberworm
Copy link
Contributor

Yes, I’ll do a release shortly. I wasn’t sure whether @oliverklee was through with all the planned refactorings which I wanted to wait for before releasing but it seems like now is a good time.

@oliverklee
Copy link
Contributor

No, I'm not through with my planned refactorings/cleanup/fixes. None of those should block a release, though. So please go ahead, @sabberworm! Thanks!

@TimWolla TimWolla mentioned this issue Dec 4, 2021
Closed
@xmav
Copy link

xmav commented Dec 10, 2021

Hi @sabberworm! Do you have updates by any chance when new version will be released ?

sabberworm added a commit that referenced this issue Dec 11, 2021
@sabberworm
Prepare release 8.4.0
e41d214 
Closes #345, #338
@sabberworm
Copy link
Contributor

@xmav version 8.4.0 is now out.

raxbg pushed a commit to raxbg/PHP-CSS-Parser that referenced this issue Sep 15, 2022
@TimWolla @raxbg
Fix PHP 8.1 compatibility in ParserState::strsplit()
58bd3c5 
> Error Message: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated

see MyIntervals#338
raxbg pushed a commit to raxbg/PHP-CSS-Parser that referenced this issue Sep 15, 2022
@sabberworm @raxbg
Prepare release 8.4.0
1b3e27a 
Closes MyIntervals#345, MyIntervals#338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sabberworm @dleffler @oliverklee @xmav