Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add local search, closes #5 #31

Merged
merged 17 commits into from Sep 9, 2019
Merged

feat: add local search, closes #5 #31

merged 17 commits into from Sep 9, 2019

Conversation

krmax44
Copy link
Collaborator

@krmax44 krmax44 commented Aug 17, 2019

Requires saberland/saber#366 to be merged in first.


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@krmax44
Copy link
Collaborator Author

krmax44 commented Aug 18, 2019

@egoist @diomed what do you think?

@egoist
Copy link
Contributor

egoist commented Aug 22, 2019

What about including saber-plugin-search in this theme by default? So users don't have to install and configure it themselves.

@krmax44
Copy link
Collaborator Author

krmax44 commented Aug 22, 2019

What about including saber-plugin-search in this theme by default? So users don't have to install and configure it themselves.

While they wouldn't have to download it, they would still have to configure it though, right? saberland/saber#160 We could pull off the workaround saberland/saber#160 (comment) to register it maybe, but then the user doesn't have control, right? 🤔

@egoist
Copy link
Contributor

egoist commented Aug 22, 2019

If we go with the old way we should only enable search in this theme when saber-plugin-search is activated

@krmax44
Copy link
Collaborator Author

krmax44 commented Aug 22, 2019

What about adding it as a dependency and extending the docs to:

theme: tailsaw
plugins:
  - saber-plugin-query-posts
  - saber-plugin-prismjs
  - saber-plugin-critical
  - saber-plugin-search

@krmax44
Copy link
Collaborator Author

krmax44 commented Aug 24, 2019

If we go with the old way we should only enable search in this theme when saber-plugin-search is activated

Implemented.

@egoist
Copy link
Contributor

egoist commented Aug 25, 2019

There're two X marks

image

@egoist
Copy link
Contributor

egoist commented Aug 25, 2019

image

the search bar should be full-width when it's not empty

@krmax44
Copy link
Collaborator Author

krmax44 commented Aug 26, 2019

There're two X marks

image

Should be fixed in Chrome, can't test with Safari.

@krmax44
Copy link
Collaborator Author

krmax44 commented Aug 27, 2019

Anything else or ready to merge?

@krmax44 krmax44 requested a review from egoist August 29, 2019 19:04
@krmax44 krmax44 merged commit c42356b into master Sep 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/local-search branch September 9, 2019 12:06
@egoist
Copy link
Contributor

egoist commented Sep 9, 2019

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@egoist egoist added the released label Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants