feat: function plots #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: add "function-plot" as dep refactor: polish Stream Types refactor: uncollapse Protocol Concepts
PaulRBerg
force-pushed
the
feat/function-plots
branch
from
a3cdb1d
to
ac63947
Compare
|
Added the graph functions @PaulRBerg! Let me know if you want me to change something. |
PaulRBerg
commented
Jun 28, 2023
Comment on lines
114
to
126
| <FunctionPlot | ||
| options={{ | ||
| data: [ | ||
| { fn: "0", range: [0, 10], color: "orange" }, | ||
| { fn: "10", range: [10, 20], color: "orange" }, | ||
| { fn: "20", range: [20, 30], color: "orange" }, | ||
| { fn: "30", range: [30, 40], color: "orange" }, | ||
| { fn: "40", range: [40, 50], color: "orange" }, | ||
| { fn: "50", range: [50, 60], color: "orange" }, | ||
| { fn: "60", range: [60, 70], color: "orange" }, | ||
| { fn: "70", range: [70, 80], color: "orange" }, | ||
| { fn: "80", range: [80, 90], color: "orange" }, | ||
| { fn: "90", range: [90, 100], color: "orange" }, |
There was a problem hiding this comment.
We can generate the points programmatically using a script like this:
...Array.from({ length: 10 }, (_, i) => ({
color: "#f77423",
fn: `${i * 10}`,
range: [i * 10, (i + 1) * 10],
})),
PaulRBerg
commented
Jun 28, 2023
| <FunctionPlot | ||
| options={{ | ||
| data: [ | ||
| { fn: "0", range: [0, 50], color: "orange" }, |
There was a problem hiding this comment.
We could use #f77423 (the brand color) instead of the generic orange.
PaulRBerg
commented
Jun 28, 2023
Comment on lines
37
to
41
| { fn: "x - 30", range: [50, 100], color: "orange" }, | ||
| { | ||
| points: [ | ||
| [50, 0], | ||
| [50, 20], |
There was a problem hiding this comment.
It would be better to use 25 as a point so that the visual representation matches the text (which refers to 1-year-cliff, 4-year-total vesting plans).
|
Thanks @maxdesalle, super cool work! Made a few refinements, and merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR integrates the function-plot package to plot the streaming curves directly on the docs website rather than redirecting the user to Desmos.
Plots
Preview
This is how it looks for Lockup Linear: