Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: cancel hanging post-download script in case it hangs. #1271

Closed
Filechaser opened this issue Apr 14, 2019 · 4 comments
Closed

Comments

@Filechaser
Copy link

See title :-)

@thezoggy
Copy link
Contributor

i've yet to see anyone report a hung post download.. usually its rar that crapped out. but thats been a thing of a past with switching to multipar... so honestly i dont really see a point of this request. also how do you determine if something is hung or just slow machine/bad hdd? also for the script to fire off.. the d/l has to finish. so right now you cant really do a watchdog style script like you want

@Safihre
Copy link
Member

Safihre commented Apr 27, 2019

It makes sense this request, sometimes people have a post-processing script that for example calls ffmpeg. Right now you have the option to cancel it though, but it's only triggered when the script write to the console. Since we only check the cancelled-state when we get any output from the script.
@Filechaser You did see the ⬛ button in the Glitter skin? Does this solve your problem?

@fryfrog
Copy link

fryfrog commented May 22, 2019

Would it be crazy to just ask people to use the timeout command in their own scripts?

@stale stale bot added the Stale Issues automatically closed because they became stale label Jun 6, 2020
@Safihre Safihre added Feature request and removed Stale Issues automatically closed because they became stale labels Jun 7, 2020
@sabnzbd sabnzbd deleted a comment from stale bot Jun 7, 2020
@sanderjo
Copy link
Contributor

sanderjo commented Jun 7, 2020

Note: what is a reasonable timeout: 1 minute, 5 minutes, or 1 hour (if you run ffmpeg on a slow NAS) ... ?

And SAB waits for a pp script to end, before it starts other scripts / downloads, right? That can be annoying.
Furthermore, maybe a sign of life, is that the pp script is writing to output. Or, more general: how do you know a script is still actively running ... ?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants