Skip to content
This repository has been archived by the owner on Oct 8, 2018. It is now read-only.

[Poll] Rely on pure upstream php-cs-fixer ? #20

Closed
DeepDiver1975 opened this issue Oct 5, 2018 · 2 comments
Closed

[Poll] Rely on pure upstream php-cs-fixer ? #20

DeepDiver1975 opened this issue Oct 5, 2018 · 2 comments

Comments

@DeepDiver1975
Copy link
Member

sabre/cs is based on php-cs-fixer 1.1 which is by now deprecated and not compatible with latest php versions (warnings are poping up on php7.3)

Porting sabre/cs to php-cs-fixer 2.0 is quite some effort since interfaces changed. From the first look it seems all custom fixer rules need to be reimplemented.

I hereby question the necessity of these custom rules and propose to deprecate sabre/CS and use pure php-cs-fixer.

@staabm @evert

@evert
Copy link
Member

evert commented Oct 5, 2018

Sounds super reasonable

@staabm
Copy link
Member

staabm commented Oct 5, 2018

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants