Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartialUpdate fails if end is missing #393

Closed
VRciF opened this issue Dec 20, 2013 · 1 comment
Closed

PartialUpdate fails if end is missing #393

VRciF opened this issue Dec 20, 2013 · 1 comment

Comments

@VRciF
Copy link

VRciF commented Dec 20, 2013

Hi,

just tried to use partialupdate plugin and found the following issue:
The documentation about the Partialupdate plugin describes the byte range header
X-Update-Range: bytes=3-6
as absolute values. So i assume that the endrange means the 6th byte of the file and not the 9th.
Given the plugin code in Sabre/DAV/PartialUpdate/Plugin.php on line 139 the $end variable is wrongly calculated in case of missing endrange

the current code
$end = ($range[1])?$range[1]:$len-1;
should be
$end = ($range[1])?$range[1]:$start+$len-1;

i already tested this problem and above solution seems working

@evert evert added bug labels Apr 4, 2014
evert added a commit that referenced this issue Apr 15, 2014
@evert
Copy link
Member

evert commented Apr 15, 2014

Sorry about this. Fixing this took way to long. WIll be included in next releases.

@evert evert closed this as completed in bdc918e Apr 15, 2014
evert added a commit that referenced this issue Apr 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants