Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename createFile/createDirectory to createNode/createCollection #923

Open
PVince81 opened this issue Dec 13, 2016 · 1 comment
Open

Rename createFile/createDirectory to createNode/createCollection #923

PVince81 opened this issue Dec 13, 2016 · 1 comment

Comments

@PVince81
Copy link
Contributor

It is more and more common (or at least in ownCloud) to use Sabre nodes for other things than files and folders. So eventually it might make sense to revamp the ICollection interface:

  • rename createFile to createNode
  • rename createDirectory to createCollection

@evert

@evert
Copy link
Member

evert commented Dec 13, 2016

This is a good idea. The Directory/Collection thing has been bugging me forever. Perhaps 4.0 is a good time to finally do this.

I'd keep createFile though, because file to us means something that has a body and can have a PUT or a GET request, so this terminology is still everywhere (unlike Directory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants