Spelling and php doc #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed most of PHPDoc parameters - Spelling mistakes - Removed ?> from the bottom of php files - Removed trailing spaces at the end of each line (my IDE did this automatically)
|
Thanks! Manually ran through.. had to make sure nothing else was changed :) As for your other points.. if( should really be if (. I have no strong feelings about spaces after comma's though. Tend to add them when I feel it's beneficial for legibility, but it's not always needed. |
This was referenced Oct 14, 2012
petrkotek
referenced
this pull request
in bigcommerce/sabre-dav
Jun 3, 2014
Several small code improvements and additional checks when expecting data in certain formats
DavidPrevot
pushed a commit
to DavidPrevot/sabre-dav
that referenced
this pull request
Oct 26, 2014
Spelling and php doc
DavidPrevot
pushed a commit
to DavidPrevot/sabre-dav
that referenced
this pull request
Oct 26, 2014
object chainsaw
Closed
This was referenced Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Evert,
I used "Code inspection" of PHPStorm to find problems in the SabreDAV code. I fixed the following:
I don't know the your Code Style Guide and I don't know your convention regarding "space after comma" in parameter lists and so on, otherwise I would have changed that, too. The same for "if(" or "if (" etc.
So if you tell me the style that has to be used I would try to fix them.