Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docblock typo #430

Merged
merged 2 commits into from
Apr 13, 2014
Merged

Fixed docblock typo #430

merged 2 commits into from
Apr 13, 2014

Conversation

staabm
Copy link
Member

@staabm staabm commented Apr 13, 2014

No description provided.

Since php 5.3.2 locks are no longer freed on fclose
@staabm
Copy link
Member Author

staabm commented Apr 13, 2014

Argh, sorry mixed the commits into one PR. Could send separated PRs if required.

@evert
Copy link
Member

evert commented Apr 13, 2014

Just saw that an explicit unluck is indeed required now... but that was it was changed since php 5.3.2. Second backwards-compatibility breaking bug in a minor version I've seen in a short time.

Thanks for these though =)

evert added a commit that referenced this pull request Apr 13, 2014
@evert evert merged commit 57e772c into sabre-io:master Apr 13, 2014
@staabm staabm deleted the patch-1 branch April 13, 2014 16:37
@evert evert added this to the 2.0 milestone May 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants