Authentication refactoring #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| function authenticate(DAV\Server $server, $realm) { | ||
| function check(RequestInterface $request, ResponseInterface $response) { |
There was a problem hiding this comment.
New methods in this class miss visibility indicator
There was a problem hiding this comment.
Should be used in all subclasses but the interface
There was a problem hiding this comment.
@staabm I've actually removed public everywhere in all the master branches.
I think when public/private/protected was a thing for the first time when PHP 5.0 first came out, I wanted to specify it everywhere.. but now I find that it looks cleaner and clearer without :P The entire public keyword is pretty much has no purpose :)
| @@ -17,7 +17,7 @@ | |||
| "php": ">=5.4.1", | |||
| "sabre/vobject": "~3.3.4", | |||
| "sabre/event" : "~2.0.0", | |||
| "sabre/http" : "~3.0.0", | |||
| "sabre/http" : "dev-master", | |||
There was a problem hiding this comment.
Needed the latest (unreleased) bugfix from that branch. Will switch back to a stable version as soon as a release happened on that side.
tcitworld
added a commit
to nextcloud/server
that referenced
this pull request
Feb 14, 2022
Since Sabre 3.0.6 this is no longer possible. @see sabre-io/dav#582 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following changes:
Fixes #191