Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing coding style, add tests/config.user.php for custom test databases #757

Merged
merged 2 commits into from
Jan 11, 2016
Merged

Fixing coding style, add tests/config.user.php for custom test databases #757

merged 2 commits into from
Jan 11, 2016

Conversation

jakobsack
Copy link
Contributor

Adds the usual style fixes.

I additionally added an option to use a custom database for testing. With the changes you can create the file tests/config.user.php with some content like

<?php
$userConfig = [
    'SABRE_MYSQLDSN'  => 'mysql:host=127.0.0.1;dbname=sabredav_test',
    'SABRE_MYSQLUSER' => 'sabredav',
    'SABRE_MYSQLPASS' => 'sabredav',
];

to set the test database without adding the environment variables.

- Fix parameters of methods
- fix indention
- remove some repeated code
@jakobsack jakobsack changed the title [WIP] Fixing coding style, add tests/config.user.php for custom test databases Fixing coding style, add tests/config.user.php for custom test databases Jan 10, 2016
evert added a commit that referenced this pull request Jan 11, 2016
Fixing coding style, add tests/config.user.php for custom test databases
@evert evert merged commit e0aae32 into sabre-io:master Jan 11, 2016
evert added a commit that referenced this pull request Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants