Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined variable in WildcardEmitterTrait #55

Closed
SamMousa opened this issue Mar 5, 2018 · 0 comments
Closed

Undefined variable in WildcardEmitterTrait #55

SamMousa opened this issue Mar 5, 2018 · 0 comments

Comments

@SamMousa
Copy link
Contributor

SamMousa commented Mar 5, 2018

While working on sabre-io/dav#1037
I noticed that this line uses an undefined variable: listenersIndex

https://github.com/sabre-io/event/blob/master/lib/WildcardEmitterTrait.php#L170

It accidentally seems to work since PHP allows defining object properties dynamically...
Either the declaration is missing or this is a typo and the intended property name is listenerIndex.
@SamMousa SamMousa mentioned this issue Mar 5, 2018
Merged
@staabm staabm closed this as completed in #56 Mar 5, 2018
staabm pushed a commit that referenced this issue Mar 5, 2018
@SamMousa @staabm
Fix typo in property name #55 (#56)
7127397 
Fixes #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SamMousa