Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update infrastructure like done in vobject #6

Merged
merged 1 commit into from Feb 2, 2020
Merged

Update infrastructure like done in vobject #6

merged 1 commit into from Feb 2, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 2, 2020

  • remove the bin-dir definition in composer.json
  • remove the bin stuff from .gitignore because it is no longer needed
  • remove IDE-specific stuff from .gitignore (people can put that sort of thing in their own .gitignore_global https://help.github.com/en/github/using-git/ignoring-files#create-a-global-gitignore )
  • add phpstsn to composer.json and cleanup special phpstan code from .travis.yml
  • run php-cs-fixer on the whole project, not just lib
  • add a scripts section to composer.json so that developers can type composer test and it will run all the tests.
  • remove enforceTimeLimit from phpunit.xml - trying to use that results in:
Error:         Package phpunit/php-invoker is required for enforcing time limits

IMO it is not worth bothering to add php-invoker ...

This update skel to be an example of how this test/CI... infrastructure is put together.

Most changes are taken from the recent changes in sabre-io/vobject#496

@phil-davis phil-davis self-assigned this Feb 2, 2020
Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@phil-davis phil-davis merged commit ae3ebbd into sabre-io:master Feb 2, 2020
@phil-davis phil-davis deleted the various-infra-changes branch February 2, 2020 13:08
- ./bin/phpstan.phar analyse -c phpstan.neon lib
- ./bin/phpunit --configuration tests/phpunit.xml
- php vendor/bin/php-cs-fixer fix --dry-run --diff
- php vendor/bin/phpstan.phar analyse -c phpstan.neon lib tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh I.. the .phar is too much here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants