New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various infra changes #496
Conversation
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
=========================================
Coverage 98.69% 98.69%
Complexity 1757 1757
=========================================
Files 66 66
Lines 4279 4279
=========================================
Hits 4223 4223
Misses 56 56 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other stuff looks good, thanks.
Getting rid of the unusual "dependencies in bin" thing is good - IMO
These entries should be in the developer's global .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks
We should make similar changes in the other sabre-io repos to standardize them. |
Agree, would be cool. Additionally I would love to have GithubActions instead of travis builds, because travis is sooo slow. In GithubActions we could also use https://github.com/staabm/annotate-pull-request-from-checkstyle then |
These are some things I came across while working on this project. Please let me know if you have any questions