Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various infra changes #496

Merged
merged 6 commits into from Feb 2, 2020
Merged

Various infra changes #496

merged 6 commits into from Feb 2, 2020

Conversation

JeroenVanOort
Copy link
Contributor

These are some things I came across while working on this project. Please let me know if you have any questions

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #496 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #496   +/-   ##
=========================================
  Coverage     98.69%   98.69%           
  Complexity     1757     1757           
=========================================
  Files            66       66           
  Lines          4279     4279           
=========================================
  Hits           4223     4223           
  Misses           56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2248d...5bd174f. Read the comment docs.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other stuff looks good, thanks.

Getting rid of the unusual "dependencies in bin" thing is good - IMO

.gitignore Show resolved Hide resolved
composer.json Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks

@phil-davis phil-davis merged commit 4972914 into sabre-io:master Feb 2, 2020
@phil-davis
Copy link
Contributor

We should make similar changes in the other sabre-io repos to standardize them.

@staabm
Copy link
Member

staabm commented Feb 2, 2020

We should make similar changes in the other sabre-io repos to standardize them.

Agree, would be cool. Additionally I would love to have GithubActions instead of travis builds, because travis is sooo slow.

In GithubActions we could also use https://github.com/staabm/annotate-pull-request-from-checkstyle then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants