Merge pull request #42 from mirago/fix-41

Fix undefined port error in parse function, when the port was not found.
sabre-io · Jul 8, 2019 · 1381865 · 1381865
2 parents 5cd3417 + 46cd057
commit 1381865
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/lib/functions.php b/lib/functions.php
@@ -373,7 +373,7 @@ function ($matches) {
         if ($matches['host']) {
             $result['host'] = $matches['host'];
         }
-        if ($matches['port']) {
+        if (isset($matches['port'])) {
             $result['port'] = (int) $matches['port'];
         }
         if (isset($matches['path'])) {

diff --git a/tests/ParseTest.php b/tests/ParseTest.php
@@ -192,6 +192,30 @@ public function parseData()
                     'fragment' => 'foo',
                 ],
             ],
+            [
+                'https://',
+                [
+                    'scheme' => 'https',
+                    'host' => null,
+                    'path' => null,
+                    'port' => null,
+                    'user' => null,
+                    'query' => null,
+                    'fragment' => null,
+                ],
+            ],
+            [
+                'https://test',
+                [
+                    'scheme' => 'https',
+                    'host' => 'test',
+                    'path' => null,
+                    'port' => null,
+                    'user' => null,
+                    'query' => null,
+                    'fragment' => null,
+                ],
+            ],
         ];
     }
 }