Workaround for parsing colons in partial URLs #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Dec 4, 2016
| // we need to encode it to avoid a PHP bug | ||
| $replaceRegExp = '/(?:[^[:ascii:]]|:)/u'; | ||
| } else { | ||
| $replaceRegExp = '/[^[:ascii:]]/u'; |
Whenever a URL contains no host part, the presence of a colon will make PHP's parse_url fail. To workaround this bug, we need to encode the colon in this situation. However we do not encode colons for full URLs.
|
Fixed indents |
|
Hey! This is a good patch, but I'm going to spend an hour or so trying an alternative route: a full regexp replacement of parse_url. The reason for this is because there is also issue #11 and I might be able to kill two birds with one stone. If I'm not successful within the hour I will give up and merge this instead. I'll also open a 1.0 branch and backport this change. |
|
Ah this patch is actually flawed. It urlencodes any |
Yes, but only does it for relative URLs, not absolute URLs. Somehow the PHP bug only affects relative URLs. Anyway, will check your other patch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a URL contains no host part, the presence of a colon will make
PHP's parse_url fail. To workaround this bug, we need to encode the
colon in this situation.
However we do not encode colons for full URLs.
Fixes #9
@evert would you accept a backport for this to the sabre-uri 1.0 series ? (not sure how to proceed, no stable branches ?)
Please review