Document InvalidUriException

[BenMorel]

_parse_fallback(), together with functions that directly or indirectly call it, are missing @throws in their respective docblocks.

This is annoying for static analysis, for example PHPStorm tells me:

This PR adds @throws where appropriate.

[BenMorel]

@evert @DeepDiver1975 Could you please consider merging & releasing?

[evert]

It's crazy that phpstorm can't infer this. Must be annoying getting these messages all the time. I don't really see any harm, but I also don't see us making this a default policy.

[BenMorel]

It's crazy that phpstorm can't infer this.

In their defense, I think that PHPStorm deliberately does not attempt to take into account any of the undocumented exceptions, treating them as "unchecked" exceptions that should usually not be caught. I think the idea is that only exceptions explicitly documented are worth reporting when not caught.

This makes sense somehow, at least until PHP—or the community—comes with clear rules regarding exception handling.

[BenMorel]

@evert Could you please tag a release?

[evert]

@staabm i don't fully remember the release process. Do we just make a git tag and update the changelog? Or is there more to it. Happy to do it but just wanted to double check.

[staabm]

Update https://github.com/sabre-io/uri/blob/master/lib/Version.php
Update changelog
Git tag

Thats what I remember :)

[evert]

Thank you =)

[evert]

2.1.2 is released

[BenMorel]

👍 Thank you!