Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canada/East-Saskatchewan removed in 2017.3 #395

Merged
merged 2 commits into from Oct 30, 2017
Merged

Canada/East-Saskatchewan removed in 2017.3 #395

merged 2 commits into from Oct 30, 2017

Conversation

remicollet
Copy link
Contributor

@remicollet remicollet commented Oct 30, 2017 •
edited

Discovered in Fedora QA since tzdata 2017c
https://apps.fedoraproject.org/koschei/package/php-sabre-vobject4?collection=f28

There was 1 error:
1) Sabre\VObject\TimeZoneUtilTest::testTimeZoneBCIdentifiers with data set #52 ('Canada/East-Saskatchewan')
Exception: DateTimeZone::__construct(): Unknown or bad timezone (Canada/East-Saskatchewan)
/builddir/build/BUILD/vobject-df9916813d1d83e4f761c4cba13361ee74196fac/tests/VObject/TimeZoneUtilTest.php:181

Also see http://git.php.net/?p=php-src.git;a=commitdiff;h=b2dfcb30eb7de65fbb0e86d5fc79419c8851c005

@evert
Copy link
Member

evert commented Oct 30, 2017

Works for me. We might want to automatically map this to America/Regina, but I doubt Canada/East-Saskatchewan is particularly popular

@evert evert merged commit 992ddc4 into sabre-io:master Oct 30, 2017
@remicollet remicollet deleted the issue-2017c branch October 31, 2017 04:08
armetiz pushed a commit to armetiz/sabre-vobject that referenced this pull request Jun 2, 2020
@remicollet @armetiz
Canada/East-Saskatchewan removed in 2017.3 (sabre-io#395)
3624c09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@remicollet @evert