Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply code style #492

Merged
merged 2 commits into from
Jan 26, 2020
Merged

Apply code style #492

merged 2 commits into from
Jan 26, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 26, 2020

  • apply php-cs-fixer code style changes
  • run php-cs-fixer in CI

This PR is on top of #491

php-cs-fixer cleaned up a lot of PHPdoc where the parameter already had a type specified in the actual function call. I guess that is the "modern" way - specify the type in the function call and do not duplicate it in the PHPdoc.

@phil-davis phil-davis self-assigned this Jan 26, 2020
@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #492 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #492      +/-   ##
============================================
+ Coverage     98.68%   98.68%   +<.01%     
  Complexity     1757     1757              
============================================
  Files            66       66              
  Lines          4269     4271       +2     
============================================
+ Hits           4213     4215       +2     
  Misses           56       56
Impacted Files Coverage Δ Complexity Δ
lib/Property/Binary.php 100% <ø> (ø) 8 <0> (ø) ⬇️
lib/Property/ICalendar/Period.php 100% <ø> (ø) 9 <0> (ø) ⬇️
lib/Parameter.php 99.2% <ø> (ø) 81 <0> (ø) ⬇️
lib/Component/VJournal.php 100% <ø> (ø) 7 <0> (ø) ⬇️
lib/Writer.php 100% <ø> (ø) 4 <0> (ø) ⬇️
lib/Property.php 98.93% <ø> (ø) 70 <0> (ø) ⬇️
lib/Property/VCard/DateAndOrTime.php 100% <ø> (ø) 75 <0> (ø) ⬇️
lib/Cli.php 98.02% <ø> (ø) 115 <0> (ø) ⬇️
lib/Property/ICalendar/Recur.php 100% <ø> (ø) 68 <0> (ø) ⬇️
lib/FreeBusyGenerator.php 98.1% <ø> (ø) 90 <0> (ø) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f9665...7508e8f. Read the comment docs.

@phil-davis phil-davis requested a review from evert January 26, 2020 12:03
@phil-davis
Copy link
Contributor Author

@staabm and/or @evert are you OK with making this much changes to keep php-cs-fixer happy?

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - just removes redundant phpdocs because of existing typehints... 👍

@staabm staabm merged commit f154971 into sabre-io:master Jan 26, 2020
@phil-davis phil-davis deleted the apply-code-style branch January 26, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants