PHP 8.1 deprecated support for null values in its APIs

lib/Cli.php

@@ -456,7 +456,7 @@ protected function convert($vObj)
      */
     protected function color($vObj)
     {
-        fwrite($this->stdout, $this->serializeComponent($vObj));
+        $this->serializeComponent($vObj);
     }
 
     /**

lib/Component.php

@@ -28,7 +28,7 @@ class Component extends Node
     /**
      * A list of properties and/or sub-components.
      *
-     * @var array
+     * @var array<string, Component|Property>
      */
     protected $children = [];
 
@@ -43,12 +43,12 @@ class Component extends Node
      * an iCalendar object, this may be something like CALSCALE:GREGORIAN. To
      * ensure that this does not happen, set $defaults to false.
      *
-     * @param string $name     such as VCALENDAR, VEVENT
-     * @param bool   $defaults
+     * @param string|null $name     such as VCALENDAR, VEVENT
+     * @param bool        $defaults
      */
     public function __construct(Document $root, $name, array $children = [], $defaults = true)
     {
-        $this->name = strtoupper($name);
+        $this->name = isset($name) ? strtoupper($name) : '';
         $this->root = $root;
 
         if ($defaults) {
@@ -238,7 +238,7 @@ public function select($name)
                 return array_filter(
                     $result,
                     function ($child) use ($group) {
-                        return $child instanceof Property && strtoupper($child->group) === $group;
+                        return $child instanceof Property && (null !== $child->group ? strtoupper($child->group) : '') === $group;
                     }
                 );
             }
@@ -249,7 +249,7 @@ function ($child) use ($group) {
         $result = [];
         foreach ($this->children as $childGroup) {
             foreach ($childGroup as $child) {
-                if ($child instanceof Property && $child->group && strtoupper($child->group) === $group) {
+                if ($child instanceof Property && (null !== $child->group ? strtoupper($child->group) : '') === $group) {
                     $result[] = $child;
                 }
             }

lib/Parameter.php

@@ -52,11 +52,12 @@ class Parameter extends Node
      */
     public function __construct(Document $root, $name, $value = null)
     {
-        $this->name = strtoupper($name);
         $this->root = $root;
         if (is_null($name)) {
             $this->noName = true;
             $this->name = static::guessParameterNameByValue($value);
+        } else {
+            $this->name = strtoupper($name);
         }
 
         // If guessParameterNameByValue() returns an empty string

lib/Property.php

@@ -30,7 +30,7 @@ abstract class Property extends Node
      *
      * This is only used in vcards
      *
-     * @var string
+     * @var string|null
      */
     public $group;
 

lib/Property/Text.php

@@ -136,16 +136,18 @@ public function getRawMimeDirValue()
             }
 
             foreach ($item as &$subItem) {
-                $subItem = strtr(
-                    $subItem,
-                    [
-                        '\\' => '\\\\',
-                        ';' => '\;',
-                        ',' => '\,',
-                        "\n" => '\n',
-                        "\r" => '',
-                    ]
-                );
+                if (!is_null($subItem)) {
+                    $subItem = strtr(
+                        $subItem,
+                        [
+                            '\\' => '\\\\',
+                            ';' => '\;',
+                            ',' => '\,',
+                            "\n" => '\n',
+                            "\r" => '',
+                        ]
+                    );
+                }
             }
             $item = implode(',', $item);
         }

tests/VObject/ComponentTest.php

@@ -60,16 +60,31 @@ public function testMagicGetGroups()
         $sub = $comp->createProperty('EMAIL', '3@3.com');
         $comp->add($sub);
 
+        $sub = $comp->createProperty('0.EMAIL', '0@0.com');
+        $comp->add($sub);
+
         $emails = $comp->email;
-        $this->assertEquals(3, count($emails));
+        $this->assertEquals(4, count($emails));
 
         $email1 = $comp->{'group1.email'};
         $this->assertEquals('EMAIL', $email1[0]->name);
         $this->assertEquals('GROUP1', $email1[0]->group);
 
+        $email0 = $comp->{'0.email'};
+        $this->assertEquals('EMAIL', $email0[0]->name);
+        $this->assertEquals('0', $email0[0]->group);
+
+        // this is supposed to return all EMAIL properties that do not have a group
         $email3 = $comp->{'.email'};
         $this->assertEquals('EMAIL', $email3[0]->name);
         $this->assertEquals(null, $email3[0]->group);
+
+        // this is supposed to return all properties that do not have a group
+        $nogroupProps = $comp->{'.'};
+        $this->assertGreaterThan(0, count($email3));
+        foreach ($nogroupProps as $prop) {
+            $this->assertEquals(null, $prop->group);
+        }
     }
 
     public function testAddGroupProperties()

tests/phpunit.xml

@@ -10,6 +10,9 @@
   failOnWarning="true"
   enforceTimeLimit="true"
   >
+  <php>
+    <ini name="error_reporting" value="E_ALL"/>
+  </php>
   <testsuites>
     <testsuite name="Sabre\VObject">
       <directory>.</directory>