New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.1] Prevent infinite loop on empty xml elements #161
Conversation
004a63b
to
321ace9
Compare
Codecov Report
@@ Coverage Diff @@
## 2.1 #161 +/- ##
============================================
- Coverage 98.82% 97.48% -1.34%
Complexity 112 112
============================================
Files 13 13
Lines 426 438 +12
============================================
+ Hits 421 427 +6
- Misses 5 11 +6
Continue to review full report at Codecov.
|
$reader->next(); | ||
|
||
return []; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels a bit hacky. Makes me wonder if this is there is a cleaner way to do this. Would for instance just a single $reader->next()
do the job (removing $reader->read()
?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THX for your feedback @evert
I can have a look at this ....
Since I already tagged the versions are you okay in accepting this implementation as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea np. If it works it works. It was a mild concern. The tests pass which is the most important =)
port of #158 to 2.1