-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libxml version instead of PHP version before calling libxml_disable_entity_loader #204
Use libxml version instead of PHP version before calling libxml_disable_entity_loader #204
Conversation
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@phil-davis what's wrong with travis? I failed to enable it ... other repos have been enabled. What's the trick? THX a lot |
Friendly ping :D |
Travis is dead for open source, they removed (severely restricted) their free plans :/ GitHub actions is a replacement but all the ci configurations needs to be updated to it |
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
As mentioned by others here, Travis is effectively dead. We migrated away from Travis in other repos of many other projects. "Someone" (tm) needs to do that here, and probably in all the sabre-io repos. Who is "someone"? ;) |
If github actions is the thing - I happily take care. |
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
IMO that's the thing to do. Thanks |
@CarlSchwan please rebase your PR so that the new ci setup can run here. THX |
…le_entity_loader In some cases older version of php 7.4 are using libxml > 2.9.0 so use the libxml version instad of the php 8.0 to see if the call of libxml is useful. Otherwise this creates some warning. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
26c59f5
to
164235d
Compare
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
============================================
- Coverage 97.31% 96.90% -0.42%
Complexity 116 116
============================================
Files 13 13
Lines 485 485
============================================
- Hits 472 470 -2
- Misses 13 15 +2
Continue to review full report at Codecov.
|
Thanks for the review |
In some cases older version of PHP 7.4 are using libxml > 2.9.0 so use
the libxml version instead of the PHP 8.0 to see if the call of libxml is
useful.
Otherwise, this creates some warning message that can spam the logs.
See https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation
Signed-off-by: Carl Schwan carl@carlschwan.eu