Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libxml version instead of PHP version before calling libxml_disable_entity_loader #204

Conversation

CarlSchwan
Copy link
Contributor

In some cases older version of PHP 7.4 are using libxml > 2.9.0 so use
the libxml version instead of the PHP 8.0 to see if the call of libxml is
useful.

Otherwise, this creates some warning message that can spam the logs.

See https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation

Signed-off-by: Carl Schwan carl@carlschwan.eu

CarlSchwan added a commit to nextcloud/3rdparty that referenced this pull request Sep 22, 2021
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan added a commit to nextcloud/3rdparty that referenced this pull request Sep 24, 2021
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@DeepDiver1975
Copy link
Member

@phil-davis what's wrong with travis? I failed to enable it ... other repos have been enabled. What's the trick? THX a lot

@CarlSchwan
Copy link
Contributor Author

Friendly ping :D

@CarlSchwan
Copy link
Contributor Author

@phil-davis what's wrong with travis? I failed to enable it ... other repos have been enabled. What's the trick? THX a lot

Travis is dead for open source, they removed (severely restricted) their free plans :/ GitHub actions is a replacement but all the ci configurations needs to be updated to it

CarlSchwan added a commit to nextcloud/3rdparty that referenced this pull request Oct 6, 2021
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan added a commit to nextcloud/3rdparty that referenced this pull request Oct 6, 2021
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@phil-davis
Copy link
Contributor

@phil-davis what's wrong with travis? I failed to enable it ... other repos have been enabled. What's the trick? THX a lot

As mentioned by others here, Travis is effectively dead. We migrated away from Travis in other repos of many other projects. "Someone" (tm) needs to do that here, and probably in all the sabre-io repos.

Who is "someone"? ;)

@DeepDiver1975
Copy link
Member

Who is "someone"? ;)

If github actions is the thing - I happily take care.

CarlSchwan added a commit to nextcloud/3rdparty that referenced this pull request Oct 6, 2021
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@phil-davis
Copy link
Contributor

If github actions is the thing - I happily take care.

IMO that's the thing to do. Thanks

@DeepDiver1975
Copy link
Member

@CarlSchwan please rebase your PR so that the new ci setup can run here. THX

…le_entity_loader

In some cases older version of php 7.4 are using libxml > 2.9.0 so use
the libxml version instad of the php 8.0 to see if the call of libxml is
useful.

Otherwise this creates some warning.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan force-pushed the work/better_libxml_version_detection branch from 26c59f5 to 164235d Compare October 7, 2021 08:14
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #204 (164235d) into master (0a39501) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #204      +/-   ##
============================================
- Coverage     97.31%   96.90%   -0.42%     
  Complexity      116      116              
============================================
  Files            13       13              
  Lines           485      485              
============================================
- Hits            472      470       -2     
- Misses           13       15       +2     
Impacted Files Coverage Δ
lib/Reader.php 97.47% <100.00%> (-1.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a39501...164235d. Read the comment docs.

@CarlSchwan
Copy link
Contributor Author

Thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants