Fixed error where valueobject has eaten too much #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty wild that people are still finding bugs, but LGTM! |
evert
approved these changes
Oct 6, 2022
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
=========================================
Coverage 96.90% 96.90%
Complexity 116 116
=========================================
Files 13 13
Lines 485 485
=========================================
Hits 470 470
Misses 15 15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
agree with that, I was surprised, that this haven't been found yet. Thanks for the great software! |
staabm
approved these changes
Oct 6, 2022
|
This has been here for a while! |
This fixes a bug, when valueobject is an empty element like <foo></foo> In this situation the deserializer did read one more, thus ending up a level higher than required
phil-davis
force-pushed
the
valueobject-runaway
branch
from
97ef8a7
to
f5073dc
Compare
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug, when valueobject is an empty element like In this situation the deserializer did read one more, thus ending up a level higher than required.
I have also attached a unit test to demonstrate the problem. With the original code this xml did throw an error.