Skip to content

Commit

Permalink
Cornerstone update 5.5.0 (#47)
Browse files Browse the repository at this point in the history
* Fixed slick issue with cloning slides

* Releasing 4.10.0-rc.6

* Fix

* Releasing 4.10.0-rc.7

* Refactor GitHub action for Bundle Test (bigcommerce#1852)

Making a few improvements to the GitHub action which does a test bundle.

* Better docs/comments
* Better name
* Support "master" or "main" branch as new forks will use `main`
  * https://www.zdnet.com/article/github-to-replace-master-with-main-starting-next-month/
  * https://github.com/github/renaming
* Add both a ruby gem cache as well as an npm cache to speed things up (CLI install is most of the time spent currently)

* Update Test Badge in README.md

* Upload bundled .zip file on PRs for easy testing

* Releasing 4.10.0

* Cornerstone 4.10 changelog update

* fix(storefront): BCTHEME-171 State of search link not announced (bigcommerce#1798)

* fix(storefront): BCTHEME-198 Face accessibility standards with social links on PDP's page (bigcommerce#1809)

* fix(storefront): BCTHEME-215 Delete item button in cart cut off from right side when in focus (bigcommerce#1823)

* fix(storefront): BCTHEME-169 Subscription notification not announced (bigcommerce#1813)

* feat(storefront)bctheme-203: add sufficient contrast on checkboxes within faceted search (bigcommerce#1815)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-167 Focus not visible on logo element (bigcommerce#1800)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront):BCTHEME-168: addcontrast for email address input according to AA standard (bigcommerce#1804)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront):BCTHEME-174 add contrast on product ratings in Quick View (bigcommerce#1799)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront):bctheme-173: add color for carousel arrows AA standard (bigcommerce#1814)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront)bctheme-220: add sufficient contrast to button border  color (bigcommerce#1817)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-229 Product carousel with related products - arrows not working (bigcommerce#1828)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)BCTHEME170: fix empty cart notification (bigcommerce#1846)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(cornerstone):BCTHEME-201: add expanded/collapsed state on add-info button (bigcommerce#1844)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)bctheme-223: fix voiceover focus not sync in faceted search (bigcommerce#1826)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront)BCTHEME75: add keyboard focus on write-a-review modal (bigcommerce#1835)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)bctheme-225:fix filter top outline on focus (bigcommerce#1829)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)BCTHEME-224: change role for sort by select (bigcommerce#1837)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront):bctheme-212 fix rating icons focus border (bigcommerce#1819)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)BCTHEME-216: fix outline styles for breadcrumbs on focus (bigcommerce#1824)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* Fixed merge conflict

* feat(content): MERC-7162 Add header bottom global region

* Removed broken import from tools.scss file

* BCTHEME-213 Add Info and Add Coupon forms on Cart Page tabbable when hidden (bigcommerce#1820)

* Releasing 4.11.0-rc.1

* Update GitHub Action to use Node 12

Node 12 is now supported for Stencil CLI, so we'll use it for this action going forward.

* Add examples of useful GitHub Actions for theme development

* Releasing 4.11.0

* fix(payments): INT-3211 Change width size for apple pay button

* Update Changelog

* feat(storefront): STRF-8630 update cornerstone to be compatible with handlebars v4

* fix(storefront): BCTHEME-197 Logo focus of voice over has wrong (100% of the screen) width (bigcommerce#1831)

* fix(storefront): BCTHEME-222 Rating and Other filter sections are not accessible by keyboard (bigcommerce#1838)

* BCTHEME-210 Carousel hidden when one or more of its images not found (bigcommerce#1816)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-214 Wishlist first option has no bottom outline when in focus (bigcommerce#1825)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-217 Product link has incorrect voice over focus on Cart Page (bigcommerce#1830)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-172 Card content truncated on zooming browser to 400% (bigcommerce#1803)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-185 Sort By dropdowns need visual focus border (bigcommerce#1833)

* BCTHEME-188 Product cards should link to products (bigcommerce#1842)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-184 Options on change modal need focus border (bigcommerce#1839)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-199 Zooming and scaling must not be disabled (bigcommerce#1843)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-202 Notification of number of products not announced (bigcommerce#1845)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-190 Content should not scroll in two directions when zoomed (bigcommerce#1853)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront)BCTHEME-205: add filter reset announcement (bigcommerce#1858)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront) BCTHEME-206: add announcement fot filtered result on Shop-by-price (bigcommerce#1854)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)BCTHEME-164: fix image in modal for IE11 (bigcommerce#1840)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-279 fix logo displaying (bigcommerce#1865)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront):add to cart notification (bigcommerce#1860)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-44 Cornerstone quick view (bigcommerce#1857)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-277 Certain Special Characters not rendering under Wishlists (bigcommerce#1873)

* fix(storefront): BCTHEME-219 Social icons not clickable in modal after reopening (bigcommerce#1874)

* fix(storefront): BCTHEME-282 Fix aria-labels for collapsibleFactory elements (bigcommerce#1868)

* BCTHEME-269 Remove layout shifts to improve CLS indicator from Lighthouse performance report (bigcommerce#1869)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-233 Cornerstone - Unable to Compare Products from Recently Viewed Items (bigcommerce#1877)

* feat(storefront): BCTHEME-290 add aria labelwith price for product list item (bigcommerce#1878)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-209 Search result not notified by screen reader (bigcommerce#1867)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-289 Add aria label with price to Product Grid Item (bigcommerce#1875)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-268 Update carousel images to improve LCP indicator from Lighthouse performance report (bigcommerce#1876)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront): BCTHEME-187 improve localization and add default and fallback messages (bigcommerce#1850)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-297 Cornerstone 4.11.0 - Product Image Carousel Becomes Unresponsive on Product Page (bigcommerce#1879)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* Resolved issues after merging PRs for 4.12 release

* Releasing 4.12.0-rc.1

* Reduce lodash usage in compare-products.js and image-gallery.js

* Releasing 4.12.0-rc.2

* Releasing 4.12.0-rc.3

* Releasing 4.12.0-rc.4

* Upload bundle analysis as part of github action

* feat(search): ES-1590 display error message if search fails

* feat: (STRF-8747) add new stencil config files to .gitignore

* Releasing 4.12.0

* Revert "Releasing 4.12.0"

* feat(storefront): BCTHEME-299 update  changelog for release 4.12

* Releasing 4.12.0

* Updated CHANGELOG.md before 4.12 release

* Reverting cornerstone version to 4.12-rc.4

* Releasing 4.12.0

* Reverting 4.12 changes

* Releasing 4.12.0

* Reverted 4.12 release commit and updated package.json versions

* Releasing 4.12.0

* Revert fix(storefront): BCTHEME-219 Social icons not clickable in modal

* Don't load social icons in quick view

* Bump stencil-utils

* fix(storefront): BCTHEME-305 Price Lists - Price in the cart is not updated when changing currency on mobile

* fix(storefront): BCTHEME-314 ccount >Payment Methods throws Server Error when using Cornerstone theme (bigcommerce#1898)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-315 Write a Review modal cause TypeError (bigcommerce#1899)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* Releasing 4.12.1

* feat(payments): PAYPAL-712 Checkout page - Smart Payment Button styli… (bigcommerce#1866)

feat(payments): PAYPAL-712 Checkout page - Smart Payment Button styling (Cornerstone)

* feat(storefront): BCTHEME-116 move tax field after grand total when tax inclusive (bigcommerce#1903)

* fix(storefront): BCTHEME-105 Cornerstone - Body text size above 14px is cut off on cart shipping dropdowns (bigcommerce#1881)

* feat(storefront): BCTHEME-69 Add tooltips for carousel bullets (buttons) (bigcommerce#1889)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-319 Write a review modal extra executions (bigcommerce#1902) (bigcommerce#1902)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-232 Faceted search filters are hidden from screen readers (bigcommerce#1897)

* fix(storefront): BCTHEME-292 Social icon tooltip displaying should be fixed (bigcommerce#1907)

* BCTHEME-293 Product list item Quick view button is not tabbable (bigcommerce#1900) (bigcommerce#1900)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-273 fix contrast ratio for Skip to Main Content element (bigcommerce#1880)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront): BCTHEME-275 add upsell banner contrast (bigcommerce#1891)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-274 fix contranst ratio for brand name (bigcommerce#1882)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-288 Shoppers are not anchor-linked to reviews on PDPs if product description tabs are enabled (bigcommerce#1883)

* fix(storefront): BCTHEME-308 HTML Entity displayed as is via system/error message on a Storefront (bigcommerce#1888)

* STRF-8769 Moved zoomSize and productSize to the upper level, cause product.js is not availabe on the Quick View (bigcommerce#1884)

* Bump versions of Ruby (bigcommerce#1905)

To fix issue bigcommerce#1904

* Changelog update

* fix(storefront): BCTHEME-104 Selecting product options doesn't update image on PDP in Internet Explorer (bigcommerce#1913)

* fix(storefront): BCTHEME-11 hide product options that are out of stock on cart (bigcommerce#1911)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-301 Header content placed out of the header block on mobile (bigcommerce#1908) (bigcommerce#1908)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-85 “Sort by” dropdown selection not reflected on search results page for News and Information tab (bigcommerce#1910) (bigcommerce#1910)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-86 Cornerstone - Text hover color does not change when Dropdown menu display mode is set to Alternative (bigcommerce#1918) (bigcommerce#1918)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-321 fix social icon tooltip overlaying (bigcommerce#1914)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* Resolving eslint error after merging

* fix(storefront): BCTHEME-30 fix misaligned tooltip for required product option (bigcommerce#1915)

Co-authored-by: yurytut1993 <66325265+yurytut1993@users.noreply.github.com>

* fix(storefront): BCTHEME-87 Product images squashed in Category view in AMP (bigcommerce#1921) (bigcommerce#1921)

* fix(storefront): BCTHEME-313 Parse HTML entities in jsContext (bigcommerce#1917)

* Added Changelog item for BCTHEME-313

* Releasing 5.0.0-rc.1

* feat(payments): PAYPAL-823 Add new banner on the cart page (bigcommerce#1901)

* Releasing 5.0.0-rc.2

* Releasing 5.0.0

* feat(storefront): BCTHEME-304 add pagination for wishlists (bigcommerce#1906)

* fix(storefront): BCTHEME-341 fix placeholder contrast ratio (bigcommerce#1933)

* fix(storefront): BCTHEME-37 Cornerstone - Image Zoom Does Not Work on Internet Explorer (bigcommerce#1923) (bigcommerce#1923)

* feat(storefront): BCTHEME-306 show price range on option selection (bigcommerce#1924)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-16 Cornerstone - loading of thumbnail image delayed on cart page (bigcommerce#1925 (bigcommerce#1925)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-193 fix not being able to change product qty with keyboard multiple times (bigcommerce#1927)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-345 define a main region on pages (bigcommerce#1929)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-346 add announcement for shipping estimator error messages (bigcommerce#1932)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront): BCTHEME-343 No tooltips provided for carousel buttons (bigcommerce#1934) (bigcommerce#1934)

* feature(storefront): Empty cart message not read by screen reader (bigcommerce#1935) (bigcommerce#1935)

* feat(storefront): BCTHEME-344 Carousel buttons do not receive focus (bigcommerce#1937) (bigcommerce#1937)

* fix(storefront): BCTHEME-155 fix recaptcha announcement for hidden content (bigcommerce#1943)

* fix(storefront): BCTHEME-379 fix non-text contrast on add to cart button (bigcommerce#1946)

* fix(storefront): BCTHEME-369 fix announcement on adding to cart by screen reader (bigcommerce#1950)

* feat(storefront): BCTHEME-373 Alt text not provided for ratings (bigcommerce#1949)

* feat(storefront): BCTHEME-78 Add Play/Pause button to carousel (bigcommerce#1944)

* fix(storefront): BCTHEME-366 Error message on PLPs not announced by screen reader (bigcommerce#1956)

* fix(storefront): BCTHEME-361 fix subscription message announcement (bigcommerce#1952)

* feat(payments): PAYPAL-903 Product Page Banners (Cornerstone) - creat… (bigcommerce#1948)

* feat(payments): PAYPAL-903 Product Page Banners (Cornerstone) - create custom price event

* feat(payments): PAYPAL-903 Product Page Banners (Cornerstone) - create custom price event
- CR fixes

Co-authored-by: Alex Saiannyi <67792608+bc-alexsaiannyi@users.noreply.github.com>

* BCTHEME-327: PDP - Empty "Description" is Hiding All Tabs When in Tab View (bigcommerce#1947)

* feat(storefront): BCTHEME-388 Dots on carousel should have similar colours as other slider controls (bigcommerce#1958)

* fix(storefront): BCTHEME-384 When default option is out of stock add to cart button does not populate for in stock options (bigcommerce#1955)

* fix(storefront): BCTHEME-383 Selecting certain option types pushes window view to the bottom of the page (bigcommerce#1959)

* Fixed merge conflict

* STRF-8898 'Show More' gives no additional options when filter clicked (bigcommerce#1945)

* Releasing 5.1.0-rc.1

* BCTHEME-387: Updates Cornerstone variants to meet the updated verticals outlined in BCTHEME-387. (bigcommerce#1962)

Co-authored-by: Dante Muñoz <dante.munoz@c02v90c0htdh.lan>

* Releasing 5.1.0-rc.2

* Releasing 5.1.0

* feat(storefront): STRF-8948 Fix Sort By on Search Page (bigcommerce#1971)

* fix(storefront): BCTHEME-368 fix announcement for shop by price filter selection (bigcommerce#1966)

* fix(storefront): BCTHEME-207 fix focus on sort by (bigcommerce#1964)

* fix(storefront): BCTHEME-385 move a phrase from html to en.json (bigcommerce#1972)

* feat(storefront): BCTHEME-390 Integrate accessibility scripts to product images slider on PDP (bigcommerce#1965)

* fix(storefront): BCTHEME-354 If multiple Pick List Options are applied, customers cannot select 'none' on both (bigcommerce#1975)

* fix(storefront): BCTHEME-356 Required checkbox message blocks the checkbox (bigcommerce#1963)

* Updated Changelog PR link for BCTHEME-212 Fixed review rating icons focus border.

* feat(storefront): BCTHEME-391 Move focus on filter items Modal after show more button was clicked and accessibility refactoring (bigcommerce#1977)

* feat(storefront) BCTHEME-381 add suffient text for swatch option (bigcommerce#1976)

* fix(storefront): BCTHEME-398 Make every product option group id unique (bigcommerce#1979)

* fix(storefront): BCTHEME-264 fix update discount banner on PDP (bigcommerce#1974)

* fix(storefront): BCTHEME-372 Error message not announced automatically (bigcommerce#1983)

* fix(storefront): BCTHEME-400 If product options are not required, the 'None' option will remain selected even if another option is chosen (bigcommerce#1980)

* fix(storefront): BCTHEME-334 Add alt attribute for no image placeholders (bigcommerce#1984)

* fix(storefront): BCTHEME-401 Category pages are creating alt attribute within the span tag (bigcommerce#1987)

* fix(storefront): BCTHEME-362 fix cut off cart button on zooming 400 (bigcommerce#1988)

* Releasing 5.2.0-rc.1

* Releasing 5.2.0

* Reverting 5.2.0 to 5.2.0-rc.1

* Releasing 5.2.0

* Revert "Releasing 5.2.0"

* Releasing 5.2.0

* Revert "Releasing 5.2.0" 2nd time

* Releasing 5.2.0

* feat(storefront): BCTHEME-200 add notifications announcement on carousel change (bigcommerce#1986)

* fix(storefront): BCTHEME-392 fixed line breaks on Dropdown Menu (bigcommerce#1996)

* fix(storefront): BCTHEME-347 Add unique identifiers to product cards (bigcommerce#1999)

* fix(storefront): BCTHEME-409 Update focus trap in Modal (bigcommerce#1998)

* fix(search): ES-2031 add error message for when star search is not availabble in facted search

* feat(search): ES-1590 render error msg for brand page

* fix(search): ES-2031 make search error more generic

* feat(search): ES-2031 add change to changelog

* feat(storefront): BCTHEME-322 add sold-out badges for products on PLP (bigcommerce#2003)

* BCTHEME-426: Insufficient link text for "Read More" links (bigcommerce#2012)

* BCTHEME-422: Announce email field as mandatory (bigcommerce#2011)

* BCTHEME-420: 'Skip to main content' is not visible (bigcommerce#2010)

* fix(storefront): BCTHEME-427 Insufficient button label on cart page (bigcommerce#2013)

* feat(storefront): BCTHEME-231 Add placeholder for failed to load carousel images and update scalability (bigcommerce#2009)

* fix(storefront): BCTHEME-429 Unlabelled edit fields on cart page (bigcommerce#2016)

* fix(storefront): BCTHEME-428 Insufficient link text on cart page (bigcommerce#2014)

* fix(storefront): BCTHEME-424 Alt text should include product name for ratings (bigcommerce#2015)

* fix(storefront): IE11 - Clicking on Search Does Not Display Search Bar (bigcommerce#2017)

* Releasing 5.3.0-rc.1

* Fixing 'Skip to main' content mobile display

* Releasing 5.3.0-rc.2

* Releasing 5.3.0

* Revert Releasing 5.3.0

* Remove AddThis for social sharing, replace with provider sharing links (bigcommerce#1997)

* Updated changelog

* Releasing 5.3.0

* fix(search): ES-2071 removed adding selected filters for price filter since not needed (bigcommerce#2018)

* fix(storefront): BCTHEME-431 remove horizontal scroll on swatch options PDP (bigcommerce#2023)

* fix(search): ES-2138 fixed count showing issue for category facet

* fix(storefront): BCTHEME-349 improve email validation for forms (bigcommerce#2029)

* feat(storefront): BCTHEME-445 replace page builder ssl settings with new global region for html widget (bigcommerce#2026)

* fix(storefront): BCTHEME-447 extend keyboard support for radio buttons (bigcommerce#2028)

* feat(storefront): BCTHEME-446 Improve performance of analyzing homepage carousel image (bigcommerce#2027)

* fix(storefront): BCTHEME-395 Wish List drop down is truncated on product page (bigcommerce#2001)

* fix(storefront): BCTHEME-434 Hamburger Menu Icon missing on Google AMP Pages (bigcommerce#2022)

* fix(storefront): BCTHEME-449 remove main tag duplicates (bigcommerce#2032)

* feat(storefront): BCTHEME-425 Incorrect focus order for product carousels (bigcommerce#2034)

* Releasing 5.4.0-rc.1

* fix(storefront): DEV-426 Fix GitHub workflows for default storefront

* Releasing 5.4.0

* fix(storefront): BCTHEME-325 Apple pay button displaying needs to be fixed (bigcommerce#2043)

* fix(storefront): BCTHEME-457 Update focus tooltip styles contrast to achieve accessibility AA Complaince (bigcommerce#2047)

* Use https:// for schema markup (bigcommerce#2039)

* fix(storefront): BCTHEME-423 Search result on search page not notified by screen reader (bigcommerce#2024)

* feat(payment): PAYPAL-968 added banner widgets to page builder (bigcommerce#2021)

* fix(storefront): bctheme-448 fix multiple swatch options (bigcommerce#2040)

* feat(storefront): BCTHEME-476 Scale focus trap for all modals (bigcommerce#2049)

* Releasing 5.5.0-rc.1

* Releasing 5.5.0

---------

Co-authored-by: Tymur Biedukhin <tymur.biedukhin@bigcommerce.com>
Co-authored-by: Nathan Booker <bookernath@users.noreply.github.com>
Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>
Co-authored-by: Alex Saiannyi <67792608+bc-alexsaiannyi@users.noreply.github.com>
Co-authored-by: yurytut1993 <66325265+yurytut1993@users.noreply.github.com>
Co-authored-by: Erik Christensen <erik.christensen@bigcommerce.com>
Co-authored-by: Juned Kazi <junedkazi@users.noreply.github.com>
Co-authored-by: Nathan Booker <nathan.booker@bigcommerce.com>
Co-authored-by: Marco Loyo <marco.loyo@bigcommerce.com>
Co-authored-by: Jairo Panduro <jairo.panduro@bigcommerce.com>
Co-authored-by: Pascal Zajac <pascalzajac@hotmail.com>
Co-authored-by: Yurii Zusik <yurii.zusik@bigcommerce.com>
Co-authored-by: sacr3dc0w <mshettles@gmail.com>
Co-authored-by: alex.saiannyi <alexander.saiannyi@bigcommerce.com>
Co-authored-by: Kevin Wang <kwang30@gmail.com>
Co-authored-by: MaxGenash <max.henash@bigcommerce.com>
Co-authored-by: David Huynh <david.huynh@bigcommerce.com>
Co-authored-by: Andrii Fetisov <54856617+bc-fetisov@users.noreply.github.com>
Co-authored-by: jairo-bc <68893868+jairo-bc@users.noreply.github.com>
Co-authored-by: Andrew A. Barber <hello@andrewbarber.me>
Co-authored-by: Brian Davenport <bdav87@gmail.com>
Co-authored-by: Olga Lashkul <32959076+helga1507@users.noreply.github.com>
Co-authored-by: Dante Munoz <35115108+DanteMunoz@users.noreply.github.com>
Co-authored-by: Dante Muñoz <dante.munoz@c02v90c0htdh.lan>
Co-authored-by: Nataliya Solyanik <nataliya.solyanik@bigcommerce.com>
Co-authored-by: bc-krishsenthilraj <39140274+bc-krishsenthilraj@users.noreply.github.com>
Co-authored-by: Senthil Krishnasamy <senthil.krishnasamy@bigcommerce.com>
Co-authored-by: Yevhenii Buliuk <82589781+bc-yevhenii-buliuk@users.noreply.github.com>
Co-authored-by: Andrii Vitvitskyi <andrii.vitvitskyi@bigcommerce.com>
  • Loading branch information
1 parent 045eddd commit ce5e05c
Show file tree
Hide file tree
Showing 80 changed files with 828 additions and 404 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ jobs:

#
# You must configure store credentials as secrets on your GitHub repo for automatic deployment via GitHub Actions
# This defaults to pushing the theme to channel ID 1, which is the default storefront. If you wish to push to an
# Alternate storefront, use a different channel ID
#

- name: Connect to store
Expand All @@ -48,4 +50,4 @@ jobs:
run: stencil init -u $URL -t $TOKEN -p 3000

- name: Push theme live, automatically deleting oldest theme if necessary
run: stencil push -a -d
run: stencil push -a -d -c 1
5 changes: 5 additions & 0 deletions .github/workflow-examples/poll_for_changed_configuration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,13 @@ jobs:
TOKEN: ${{ secrets.STENCIL_ACCESS_TOKEN_PRODUCTION }}
run: stencil init -u $URL -t $TOKEN -p 3000

<<<<<<< HEAD
- name: Check for an updated configuration on the live store
run: stencil pull
=======
- name: Check for an updated configuration on the live default storefront (channel ID 1)
run: stencil pull -c 1
>>>>>>> 5.5.0

- name: Create Pull Request
id: cpr
Expand Down
23 changes: 22 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,28 @@

## Draft

## 5.3.0 (03-24-2021)
## 5.5.0 (05-20-2021)
- Scale focus trap for all modals. [#2049](https://github.com/bigcommerce/cornerstone/pull/2049)
- Fixed displaying swatch name for multiple swatch options on page. [#2040](https://github.com/bigcommerce/cornerstone/pull/2040)
- Added settings for payment banners. [#2021](https://github.com/bigcommerce/cornerstone/pull/2021)
- Use https:// for schema markup. [#2039](https://github.com/bigcommerce/cornerstone/pull/2039)
- Update focus tooltip styles contrast to achieve accessibility AA Complaince. [#2047](https://github.com/bigcommerce/cornerstone/pull/2047)
- Apple pay button displaying needs to be fixed. [#2043](https://github.com/bigcommerce/cornerstone/pull/2043)

## 5.4.0 (04-26-2021)
- Incorrect focus order for product carousels. [#2034](https://github.com/bigcommerce/cornerstone/pull/2034)
- Removed duplicates of main tag.[#2032](https://github.com/bigcommerce/cornerstone/pull/2032)
- Hamburger Menu Icon missing on Google AMP Pages. [#2022](https://github.com/bigcommerce/cornerstone/pull/2022)
- Wish List drop down is truncated on product page. [#2001](https://github.com/bigcommerce/cornerstone/pull/2001)
- Improve performance of analyzing homepage carousel images. [#2027](https://github.com/bigcommerce/cornerstone/pull/2027)
- Added keyboard support on radio buttons. [#2028](https://github.com/bigcommerce/cornerstone/pull/2028)
- Replace SSL settings in Page builder with global region for SSL certificate. [#2026](https://github.com/bigcommerce/cornerstone/pull/2026)
- fixed email address validation in forms. [#2029](https://github.com/bigcommerce/cornerstone/pull/2029)
- Fixed unnecessary horizontal scroll on swatch options on PDP. [#2023](https://github.com/bigcommerce/cornerstone/pull/2023)
- Always showing product counts for Category facet in the faceted search results page. [#2035](https://github.com/bigcommerce/cornerstone/pull/2035)

## 5.3.0 (03-25-2021)
- Remove AddThis for social sharing, replace with provider sharing links. [#1997](https://github.com/bigcommerce/cornerstone/pull/1997)
- IE11 - Clicking on Search Does Not Display Search Bar. [#2017](https://github.com/bigcommerce/cornerstone/pull/2017)
- Alt text should include product name for ratings. [#2015](https://github.com/bigcommerce/cornerstone/pull/2015)
- Changed insufficient "Change" link text on cart page. [#2014](https://github.com/bigcommerce/cornerstone/pull/2014)
Expand Down
3 changes: 3 additions & 0 deletions assets/js/test-unit/theme/global/modal.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ describe('Modal', () => {
beforeEach(() => {
$element = attachHtml(`
<div id="modal" class="modal" data-reveal>
<button class="modal-close" type="button">
<span aria-hidden="true">&#215;</span>
</button>
<div class="modal-content"></div>
<div class="loadingOverlay"></div>
</div>
Expand Down
8 changes: 8 additions & 0 deletions assets/js/theme/cart.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import CartItemDetails from './common/cart-item-details';
export default class Cart extends PageManager {
onReady() {
this.$modal = null;
this.$cartPageContent = $('[data-cart]');
this.$cartContent = $('[data-cart-content]');
this.$cartMessages = $('[data-cart-status]');
this.$cartTotals = $('[data-cart-totals]');
Expand All @@ -18,9 +19,16 @@ export default class Cart extends PageManager {
this.$activeCartItemId = null;
this.$activeCartItemBtnAction = null;

this.setApplePaySupport();
this.bindEvents();
}

setApplePaySupport() {
if (window.ApplePaySession) {
this.$cartPageContent.addClass('apple-pay-supported');
}
}

cartUpdate($target) {
const itemId = $target.data('cartItemid');
this.$activeCartItemId = itemId;
Expand Down
8 changes: 3 additions & 5 deletions assets/js/theme/common/aria/radioOptions.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const setCheckedRadioItem = (itemCollection, itemIdx) => {
}

$item.attr('aria-checked', true).prop('checked', true).focus();
$item.trigger('change');
});
};

Expand All @@ -31,21 +32,18 @@ const handleItemKeyDown = itemCollection => e => {
}

switch (keyCode) {
case ariaKeyCodes.RETURN:
case ariaKeyCodes.SPACE: {
setCheckedRadioItem(itemCollection, itemIdx);
break;
}
case ariaKeyCodes.LEFT:
case ariaKeyCodes.UP: {
const prevItemIdx = calculateTargetItemPosition(lastCollectionItemIdx, itemIdx - 1);
itemCollection.get(prevItemIdx).focus();
setCheckedRadioItem(itemCollection, itemIdx - 1);
break;
}
case ariaKeyCodes.RIGHT:
case ariaKeyCodes.DOWN: {
const nextItemIdx = calculateTargetItemPosition(lastCollectionItemIdx, itemIdx + 1);
itemCollection.get(nextItemIdx).focus();
setCheckedRadioItem(itemCollection, itemIdx + 1);
break;
}

Expand Down
1 change: 1 addition & 0 deletions assets/js/theme/common/carousel/constants.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const FOCUSABLE_ELEMENTS_SELECTOR = '[href], button, input, textarea, select, details, [contenteditable="true"], [tabindex]';
51 changes: 25 additions & 26 deletions assets/js/theme/common/carousel/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,70 +2,69 @@ import 'slick-carousel';

import {
activatePlayPauseButton,
analizeSlides,
arrowAriaLabling,
dotsSetup,
getActiveSlideIdxAndSlidesQuantity,
handleImageAspectRatio,
handleImageLoad,
setTabindexes,
tooltipSetup,
refreshFocus,
updateTextWithLiveData,
} from './utils';

/**
* returns activeSlideIdx and slidesQuantity
* based on provided carousel settings
* @param {Object} $slickSettings
* @returns {Object}
*/
const extractSlidesDetails = ({
slideCount, $slides, options: { slidesToShow, slidesToScroll },
}) => getActiveSlideIdxAndSlidesQuantity(
slideCount,
slidesToShow,
slidesToScroll,
$slides,
);
export const setCarouselState = ({ delegateTarget }, carouselObj) => {
const carouselObjCurrent = carouselObj || delegateTarget.slick;
const { $slider } = carouselObjCurrent;

$slider.data('state', getActiveSlideIdxAndSlidesQuantity(carouselObjCurrent));
};

export const onUserCarouselChange = ({ data }, context, $slider) => {
const $activeSlider = $slider || data;
const $parentContainer = $activeSlider.hasClass('productView-thumbnails') ? $('.productView-images') : $activeSlider;
const { activeSlideIdx, slidesQuantity } = extractSlidesDetails($activeSlider[0].slick);
const $parentContainer = $activeSlider.hasClass('productView-thumbnails') ? $activeSlider.parent('.productView-images') : $activeSlider;
const { activeSlideIdx, slidesQuantity } = $activeSlider.data('state');
const $carouselContentElement = $('[data-carousel-content-change-message]', $parentContainer);
const carouselContentAnnounceMessage = updateTextWithLiveData(context.carouselContentAnnounceMessage, (activeSlideIdx + 1), slidesQuantity);

$carouselContentElement.text(carouselContentAnnounceMessage);
};

export const onSlickCarouselChange = (e, carousel, context) => {
export const onSlickCarouselChange = (e, carouselObj, context) => {
const {
$dots,
$slider,
$prevArrow,
$nextArrow,
} = carousel;
options: { infinite },
} = carouselObj;

const { activeSlideIdx, slidesQuantity } = extractSlidesDetails(carousel);
const { activeSlideIdx, slidesQuantity } = $slider.data('state') || getActiveSlideIdxAndSlidesQuantity(carouselObj);

dotsSetup($dots, activeSlideIdx, slidesQuantity, context);
arrowAriaLabling($prevArrow, $nextArrow, activeSlideIdx, slidesQuantity, context.carouselArrowAndDotAriaLabel);
setTabindexes($slider.find('.slick-slide'));
tooltipSetup($prevArrow, $nextArrow, $dots);
activatePlayPauseButton(carousel, slidesQuantity, context);
arrowAriaLabling($prevArrow, $nextArrow, activeSlideIdx, slidesQuantity, infinite, context.carouselArrowAndDotAriaLabel);
analizeSlides($slider.find('.slick-slide'));
refreshFocus($prevArrow, $nextArrow, $dots, $slider, activeSlideIdx, slidesQuantity, infinite);

$slider.data('state', null);
};

export default function (context) {
$('[data-slick]').each((idx, carousel) => {
// getting element using find to pass jest test
const $carousel = $(document).find(carousel);

$carousel.on('init breakpoint swipe', setCarouselState);
$carousel.on('click', '.slick-arrow, .slick-dots', setCarouselState);

$carousel.on('init breakpoint', (e, carouselObj) => activatePlayPauseButton(e, carouselObj, context));
$carousel.on('init afterChange', (e, carouselObj) => onSlickCarouselChange(e, carouselObj, context));
$carousel.on('click', '.slick-arrow, .slick-dots', $carousel, e => onUserCarouselChange(e, context));
$carousel.on('swipe', (e, carouselObj) => onUserCarouselChange(e, context, carouselObj.$slider));

if ($carousel.hasClass('heroCarousel')) {
$carousel.on('init afterChange', handleImageLoad);
$carousel.on('swipe', handleImageAspectRatio);
$carousel.on('click', '.slick-arrow, .slick-dots', $carousel, handleImageAspectRatio);
$carousel.on('click', '.slick-arrow, .slick-dots', handleImageAspectRatio);

// Alternative image styling for IE, which doesn't support objectfit
if (typeof document.documentElement.style.objectFit === 'undefined') {
Expand Down
48 changes: 25 additions & 23 deletions assets/js/theme/common/carousel/utils/activatePlayPauseButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,49 +2,51 @@ import { throttle } from 'lodash';

const PLAY_ACTION = 'slickPlay';
const PAUSE_ACTION = 'slickPause';
const IS_ACTIVATED_DATA_ATTR = 'is-activated';

export default (carousel, slidesQuantity, context) => {
const { $slider, $dots, speed } = carousel;
const $playPauseButton = $slider.find('[data-play-pause-button]');

if ($playPauseButton.length === 0) return;

$playPauseButton.css('display', slidesQuantity < 2 ? 'none' : 'block');

if ($playPauseButton.data(IS_ACTIVATED_DATA_ATTR)) return;

const updateButtonLabels = (context) => {
const {
carouselPlayPauseButtonPlay,
carouselPlayPauseButtonPause,
carouselPlayPauseButtonAriaPlay,
carouselPlayPauseButtonAriaPause,
} = context;

const updateLabels = action => {
$playPauseButton
return ($button, action) => {
$button
.text(action === PLAY_ACTION
? carouselPlayPauseButtonPause : carouselPlayPauseButtonPlay)
.attr('aria-label', action === PLAY_ACTION
? carouselPlayPauseButtonAriaPause : carouselPlayPauseButtonAriaPlay);
};
};
let updateButtonLabelsWithContext;

const onPlayPauseClick = () => {
const action = carousel.paused ? PLAY_ACTION : PAUSE_ACTION;
export default (e, carouselObj, context) => {
const { $slider, $dots, options: { speed } } = carouselObj;
const $playPauseButton = $slider.find('[data-play-pause-button]');

$slider.slick(action);
updateLabels(action);
};
if ($playPauseButton.length === 0) return;

// for correct carousel controls focus order
if ($dots) {
$playPauseButton.insertBefore($dots);
} else $slider.append($playPauseButton);

$playPauseButton.on('click', throttle(onPlayPauseClick, speed, { trailing: false }));
$playPauseButton.data(IS_ACTIVATED_DATA_ATTR, true);
const { slidesQuantity } = $slider.data('state');
$playPauseButton.css('display', slidesQuantity > 1 ? 'block' : 'none');

if (carousel.breakpoints.length) {
$slider.on('breakpoint', () => updateLabels(PLAY_ACTION));
if (e.type === 'init') updateButtonLabelsWithContext = updateButtonLabels(context);

if (e.type === 'breakpoint') {
updateButtonLabelsWithContext($playPauseButton, PLAY_ACTION);
return;
}

const onPlayPauseClick = () => {
const action = carouselObj.paused ? PLAY_ACTION : PAUSE_ACTION;

$slider.slick(action);
updateButtonLabelsWithContext($playPauseButton, action);
};

$playPauseButton.on('click', throttle(onPlayPauseClick, speed, { trailing: false }));
};
14 changes: 14 additions & 0 deletions assets/js/theme/common/carousel/utils/analizeSlides.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { FOCUSABLE_ELEMENTS_SELECTOR } from '../constants';

export default ($slides) => {
$slides.each((idx, slide) => {
const $slide = $(slide);
const tabIndex = $slide.hasClass('slick-active') ? 0 : -1;

if ($slide.is(FOCUSABLE_ELEMENTS_SELECTOR)) $slide.attr('tabindex', tabIndex);

$slide.find(FOCUSABLE_ELEMENTS_SELECTOR).each((index, child) => {
$(child).attr('tabindex', tabIndex);
});
});
};
15 changes: 12 additions & 3 deletions assets/js/theme/common/carousel/utils/arrowAriaLabling.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,26 @@
import updateTextWithLiveData from './updateTextWithLiveData';
import tooltipSetup from './tooltipSetup';

export default ($prevArrow, $nextArrow, activeSlideIdx, slidesQuantity, ariaLabel) => {
export default ($prevArrow, $nextArrow, activeSlideIdx, slidesQuantity, isInfinite, ariaLabel) => {
if (slidesQuantity < 2 || !$prevArrow || !$nextArrow) return;

const activeSlideNumber = activeSlideIdx + 1;

const prevSlideNumber = activeSlideIdx === 0 ? slidesQuantity : activeSlideNumber - 1;
const arrowLeftText = updateTextWithLiveData(ariaLabel, prevSlideNumber, slidesQuantity);

$prevArrow.attr('aria-label', arrowLeftText);
$prevArrow.attr({
'aria-label': arrowLeftText,
tabindex: !isInfinite && activeSlideIdx === 0 ? -1 : 0,
});
tooltipSetup($prevArrow);

const nextSlideNumber = activeSlideIdx === slidesQuantity - 1 ? 1 : activeSlideNumber + 1;
const arrowRightText = updateTextWithLiveData(ariaLabel, nextSlideNumber, slidesQuantity);

$nextArrow.attr('aria-label', arrowRightText);
$nextArrow.attr({
'aria-label': arrowRightText,
tabindex: !isInfinite && activeSlideIdx === slidesQuantity - 1 ? -1 : 0,
});
tooltipSetup($nextArrow);
};
4 changes: 3 additions & 1 deletion assets/js/theme/common/carousel/utils/dotsSetup.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import updateTextWithLiveData from './updateTextWithLiveData';
import tooltipSetup from './tooltipSetup';

export default ($dots, activeSlideIdx, slidesQuantity, { carouselArrowAndDotAriaLabel, carouselActiveDotAriaLabel }) => {
if (!$dots) return;
Expand All @@ -14,7 +15,8 @@ export default ($dots, activeSlideIdx, slidesQuantity, { carouselArrowAndDotAria
const dotLabelText = updateTextWithLiveData(carouselArrowAndDotAriaLabel, idx + 1, slidesQuantity);
const dotSlideStatusText = idx === activeSlideIdx ? `, ${carouselActiveDotAriaLabel}` : '';
const dotAriaLabel = `${dotLabelText}${dotSlideStatusText}`;
const $dotButton = $(dot).find('[data-carousel-dot]');

$(dot).find('[data-carousel-dot]').attr('aria-label', dotAriaLabel);
tooltipSetup($dotButton.attr('aria-label', dotAriaLabel));
});
};
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default (slideCount, slidesToShow, slidesToScroll, $slides) => {
export default ({ slideCount, $slides, options: { slidesToShow, slidesToScroll } }) => {
const lastVisibleIdx = $slides.get().reduce((acc, curr, idx) => {
if ($(curr).hasClass('slick-active')) return idx;
return acc;
Expand Down
10 changes: 3 additions & 7 deletions assets/js/theme/common/carousel/utils/getActiveSlideInfo.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,12 @@ export default ({ $slider }, isAnalyzedDataAttr) => {
if (isAnalyzedSlide) return { isAnalyzedSlide };

const $activeSlideImg = $activeSlide.find('.heroCarousel-image');

const attrsObj = {
src: $activeSlideImg.attr('src'),
srcset: $activeSlideImg.attr('srcset'),
sizes: $activeSlideImg.attr('sizes'),
};
const activeSlideImgNode = $activeSlideImg[0];

return {
attrsObj,
$slider,
$activeSlide,
$activeSlideImg,
activeSlideImgNode,
};
};
Loading

0 comments on commit ce5e05c

Please sign in to comment.