Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-chain gauge factory contracts w/ basic tests and deploy scripts #684

Merged
merged 75 commits into from
Sep 14, 2022

Conversation

lilPlumberBoy
Copy link
Contributor

@lilPlumberBoy lilPlumberBoy commented Aug 10, 2022

Adds cross chain gauge factory contracts and deploy scripts for frontend development.

lilPlumberBoy and others added 30 commits August 7, 2022 16:13
* updates pool reg for FraxBP USDs pool

* ran lint fix

* fixed typo in pool registry update

* Skip script from running

Co-authored-by: Jongseung Lim <penandlim@gmail.com>
* Add separate tests for permissionless contracts

* Change test name to be accurate

* added deploys for non-flashload permissionless swaps

Co-authored-by: Michael Daly <dalymike102@gmail.com>
penandlim and others added 11 commits September 12, 2022 22:59
* Uses immutables
* Removes unnecessary storage var
* Added USDT pool deploy, fixed typo in verify script

* deployed to kava_mainnet

* fixed registering of pools

* registered USDT pool

* verified new USDT Pool deployment
* Update hardhat to 2.11.1 and associated dependencies

* Update solidity-coverage package version

* Update tests to use the ignore tx type flag
* Use chai's closeTo comparison to approximate

* Add appropriate fixture deploy tags to all tests

* Increase line coverage

* Add tests for collecting fees on PermissionlessMetaSwapFlashLoan
instance
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #684 (f14521c) into master (a86904b) will decrease coverage by 4.52%.
The diff coverage is 42.34%.

@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
- Coverage   91.29%   86.77%   -4.53%     
==========================================
  Files          34       43       +9     
  Lines        1758     2049     +291     
  Branches      280      341      +61     
==========================================
+ Hits         1605     1778     +173     
- Misses        153      271     +118     
Impacted Files Coverage Δ
...ontracts/xchainGauges/bridgers/OptimismBirdger.sol 0.00% <0.00%> (ø)
contracts/xchainGauges/mock/AnyCallExecutor.sol 0.00% <0.00%> (ø)
contracts/xchainGauges/mock/MockBridger.sol 28.57% <28.57%> (ø)
contracts/xchainGauges/oracles/ChildOracle.sol 37.83% <37.83%> (ø)
...ontracts/xchainGauges/bridgers/ArbitrumBirdger.sol 40.62% <40.62%> (ø)
contracts/xchainGauges/oracles/RootOracle.sol 45.16% <45.16%> (ø)
contracts/xchainGauges/AnycallTranslator.sol 62.50% <62.50%> (ø)
contracts/xchainGauges/RewardForwarder.sol 100.00% <100.00%> (ø)
contracts/xchainGauges/mock/MockAnycall.sol 100.00% <100.00%> (ø)
contracts/permissionless/PermissionlessSwap.sol 55.55% <0.00%> (-1.59%) ⬇️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@penandlim penandlim changed the title Mike/xchain factory gauges Add cross chain gauge factory contracts w/ basic tests and deploy scripts Sep 13, 2022
@penandlim penandlim changed the title Add cross chain gauge factory contracts w/ basic tests and deploy scripts Add x-chain gauge factory contracts w/ basic tests and deploy scripts Sep 13, 2022
@penandlim penandlim marked this pull request as ready for review September 13, 2022 10:33
Copy link
Contributor

@penandlim penandlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the initial branch. Then making smaller PRs for increasing test coverage.

@penandlim penandlim merged commit 241e2fc into master Sep 14, 2022
@penandlim penandlim deleted the mike/xchain_factory_gauges branch September 14, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants