Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDT pool deploy #703

Merged
merged 5 commits into from
Sep 13, 2022
Merged

USDT pool deploy #703

merged 5 commits into from
Sep 13, 2022

Conversation

lilPlumberBoy
Copy link
Contributor

@lilPlumberBoy lilPlumberBoy commented Sep 8, 2022

Description

Deploy USDT Pool with Multichain bridged assets

Deployment checklist

List any new deployments that is expected to be saved after running the deploy task. After running the scripts, check off each item if they are successfully deployed.

  • USDTPool
  • USDTLPToken

Deployment verification

Please provide explorer links to the deployed contracts and verify them using either standard solcInputs json or manually flattened contracts using npx hardhat flatten. After verifying them, check off each item.

  • Link to USDTPool on etherscan
  • Link to USDTPoolLPToken on etherscan

Checklist:

  • Any imported tokens's addresses are verified against official docs
  • If any existing contracts are changed, ensure the saved deployments are removed before running the deploy scripts
  • If deploying a new pool on a testnet, ensure there is liquidity by providing the test tokens to a DEX.
  • If possible, the deploy scripts are tested against forked mainnet or local hardhat node.
  • Newly deployed contracts match the expected list of new deployments
  • All newly deployed contracts are verified on explorers

@lilPlumberBoy lilPlumberBoy requested a review from a team September 8, 2022 16:20
hannespfeiffer
hannespfeiffer previously approved these changes Sep 9, 2022
@lilPlumberBoy lilPlumberBoy changed the title USDT pool deploy, fixed typo in verify script USDT pool deploy Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #703 (d35dd0e) into master (1eadcbf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #703   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files          34       34           
  Lines        1758     1758           
  Branches      280      280           
=======================================
  Hits         1605     1605           
  Misses        153      153           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@penandlim penandlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
nitpick: you can use all() from hardhat-deploy to get all contracts instead of providing list yourself.
https://github.com/wighawag/hardhat-deploy#the-deployments-field

Alternative is to parse deployments folder and retrieve the file names yourself.

@penandlim penandlim merged commit a86904b into master Sep 13, 2022
@penandlim penandlim deleted the mike/kava_multichain_2pool branch September 13, 2022 05:35
penandlim pushed a commit that referenced this pull request Sep 13, 2022
* Added USDT pool deploy, fixed typo in verify script

* deployed to kava_mainnet

* fixed registering of pools

* registered USDT pool

* verified new USDT Pool deployment
penandlim added a commit that referenced this pull request Sep 14, 2022
…#684)

* adding files is state where tests work

* root gauge factory tests, child gauge factory initialize

* child gauge initial tests

* added oracles and arbitrum bridger

* fixed oracles and added test for oracle

* updated todo comments

* updated Anycall translator and anycall mock contracts

* added rootgaugeFactory tests

* updated mock anycall contract

* updated translator / mock anycall contracts

* finalized AnycallTranslator contract

* updated translator contract with all accepted function calls

* finalized oracle contracts

* finalized gauge implementations

* added Optimism bridger, cleaned up comments

* removed delegatecall from translator

* naming changes

* Script for enabling on chain gauge voting (#691)

* updated logic of RootGauge

* added logic for having a RootGauge name

* fixed typing of name(), added to factory tests

* updated tests to successfully deploy root gauge

* Added to RootGauge Factory tests

* added deposit and rescue functios to translator

* added fixture to RootGauge Factory Test

* added todo comments

* Add deploy script and deployment data for non-flashloan swaps (#690)

* Updates pool reg for FraxBP USDs pool (#686)

* updates pool reg for FraxBP USDs pool

* ran lint fix

* fixed typo in pool registry update

* Skip script from running

Co-authored-by: Jongseung Lim <penandlim@gmail.com>

* Add separate tests for permissionless contracts (#681)

* Add separate tests for permissionless contracts

* Change test name to be accurate

* added deploys for non-flashload permissionless swaps

Co-authored-by: Michael Daly <dalymike102@gmail.com>

* Fix root gauge factory test.
- fix capitalization

* Fix capitalization in file names

* Fix test imports and types
- import from typechain

* Lint x chain gauges contracts

* Deploy root gauge factory on hardhat

* Deploy script for fake USDC (#693)

* Run prepare scripts by default on hardhat (#694)

* Run prepare scripts by default on hardhat

* Specify tags for swapMigrator tests

* Fix saving Multicall3 with abi

* Ensure no other deploy scripts are ran except the specified

* Add the deployed gauge to gauge controller

* Updates hardhat and migrate from waffle to hardhat chai matchers (#696)

* Migrate from waffle to hardhat chai matchers

* Linting fix

* Fix function name to include parameters for overloading

* Adds 2 new node dependencies (#699)

- hardhat-tracer
- openzepplin 4.4.0 upgradable

* Update AnyCallTranslator to be a proxy. Updates the test.

* Change signatures to match up between contracts

* Add test for sidechain -> root chain deploy_gauge()

* Fix encoding type

* Use proxy in deploy script

* ChildOracle emits an event when recieving

* Cleans up hardhat config file and moves tasks into tasks folder (#698)

* Cleans up hardhat config file and moves tasks into tasks folder

* Remove unnecessary dependency

* Add comments to tasks

* Fix param casing

* Add deploy scripts for optimism mainnet

* Improve fork settings (#700)

* Add deploy scripts

* Deploy a child gauge for SaddleFRAXBPPoolLPToken

* Adds `patch-package` to apply fix for Arbitrum Nitro (#701)

* Update USDS pool in pool registry (#702)

* Fix duplicate contract names

* Add deploy scripts for mainnet. Only run when forking for now

* Update RootOracle contract and test

* Uses immutables
* Removes unnecessary storage var

* USDT pool deploy (#703)

* Added USDT pool deploy, fixed typo in verify script

* deployed to kava_mainnet

* fixed registering of pools

* registered USDT pool

* verified new USDT Pool deployment

* Update hardhat to 2.11.1 and associated dependencies (#704)

* Update hardhat to 2.11.1 and associated dependencies

* Update solidity-coverage package version

* Update tests to use the ignore tx type flag

* Test for each storage variable separately

* Change file name cases to be in consistent style

* Update RootGaugeFactory tests

* Include prefix and suffix on Gauge names

* Update ChildGaugeFactory test

* Specify deploy tags for each test (#705)

* Use chai's closeTo comparison to approximate

* Add appropriate fixture deploy tags to all tests

* Increase line coverage

* Add tests for collecting fees on PermissionlessMetaSwapFlashLoan
instance

Co-authored-by: Jongseung (John) Lim <penandlim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants