Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear form fields once the timesheet entry is submitted #266

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

murtaza-bagwala
Copy link
Contributor

Notion card

https://www.notion.so/saeloun/6afc9500b2cc42af86be55f37894fb09?v=b4528f26f4424af7beaf036262796cb3&p=78c15513bdbd4515ad57d362fbcb6c8b

Summary

Clear the notes field and hours field after a timesheet entry is created.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-266 April 14, 2022 15:03 Inactive
Copy link
Contributor

@shivamsinghchahar shivamsinghchahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@supriya3105 supriya3105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murtaza-bagwala Can we also reset the client & project.

Also, while clearing the hours , reset the field to 00:00 . I think while adding the entries if we do not add it in this format 00:00 the entries do not get added.

@supriya3105 supriya3105 merged commit 0e2824f into develop Apr 15, 2022
@akhilgkrishnan akhilgkrishnan deleted the clear-notes-and-duration-after-save branch April 19, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants