Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support signing in the provider #218

Merged
merged 5 commits into from
Sep 20, 2021

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Sep 9, 2021

Resolves #204 by handling eth_sign and personal_sign requests

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2021

🦋 Changeset detected

Latest commit: 21884da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@gnosis.pm/safe-apps-provider Minor
@gnosis.pm/safe-apps-web3-react Patch
@gnosis.pm/safe-apps-web3modal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@mmv08 mmv08 requested a review from rmeissner September 9, 2021 13:19
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 12 0
Ignored 3 N/A
  • Result: ✅ success

  • Annotations: 12 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


[warning] @typescript-eslint/no-explicit-any

Disallow usage of the any type


Report generated by eslint-plus-action

@CyrusOfEden
Copy link

This looks great! Game changing

@mmv08 mmv08 merged commit 8d86ff2 into development Sep 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2021
@mmv08 mmv08 deleted the feature/signing-via-provider branch September 20, 2021 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants