Add native currency support to SwapOrderHelper #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `SwapOrderHelper` now supports swaps with the respective chain native tokens. - The Native Token is represented with the address `0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE` (https://docs.cow.fi/cow-protocol/reference/sdks/cow-sdk/modules#buy_eth_address) - If we fail to retrieve the native currency data (from the Safe Config Service), the decoding fails, and it attempts to decode it as a Custom transaction. The main reason for this is that Native Currencies might have different decimals which are important for showing the correct number of tokens being transferred.
Pull Request Test Coverage Report for Build 8893325428Details
💛 - Coveralls |
iamacook
reviewed
Apr 30, 2024
| chainId: string; | ||
| address: `0x${string}`; | ||
| }): Promise<Token> { | ||
| if (args.address === SwapOrderHelper.NATIVE_CURRENCY_ADDRESS) { |
There was a problem hiding this comment.
Are we sure that args.address with always be checksummed? It would be a bit safer to either checksum args.address or compare them in lowercase. What do you think?
There was a problem hiding this comment.
Auto-merge merged the commit before I was able to tackle this. I will open a follow up PR.
There was a problem hiding this comment.
Tackled it here: #1493
hectorgomezv
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwapOrderHelpernow supports swaps with the respective chain native tokens.0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE(https://docs.cow.fi/cow-protocol/reference/sdks/cow-sdk/modules#buy_eth_address)