Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform lower case comparison for native currency #1493

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Perform lower case comparison for native currency #1493

merged 1 commit into from
Apr 30, 2024

Conversation

fmrsabino
Copy link
Collaborator

  • Ignores the checksummed state of the provided addresses – one address is provided by a 3rd party, and we should be able to correctly perform this comparison regardless of the representation of the respective address.

@fmrsabino fmrsabino self-assigned this Apr 30, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner April 30, 2024 11:01
@fmrsabino fmrsabino mentioned this pull request Apr 30, 2024
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8893616585

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.201%
Totals Coverage Status
Change from base Build 8893556438: 0.03%
Covered Lines: 6899
Relevant Lines: 7215
💛 - Coveralls

@fmrsabino fmrsabino merged commit 93f6a75 into main Apr 30, 2024
16 checks passed
@fmrsabino fmrsabino deleted the lowercase-comparision-native-swaps branch April 30, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamacook iamacook iamacook approved these changes

Assignees

@fmrsabino fmrsabino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmrsabino @coveralls @iamacook