Add ZerionBalancesSchema tests #1637
Conversation
| @@ -19,41 +19,41 @@ export type ZerionBalance = z.infer<typeof ZerionBalanceSchema>; | |||
|
|
|||
| export type ZerionBalances = z.infer<typeof ZerionBalancesSchema>; | |||
|
|
|||
| const ZerionImplementationSchema = z.object({ | |||
| export const ZerionImplementationSchema = z.object({ | |||
There was a problem hiding this comment.
The schemas in this file are exported to test them on the ad hoc tests.
| const fiatBalance = value ? getNumberString(value) : null; | ||
| const fiatConversion = getNumberString(zb.attributes.price); | ||
| const fiatConversion = price ? getNumberString(price) : null; |
There was a problem hiding this comment.
attributes.price is not marked as required in the Zerion API docs, so I've changed this to reflect the possibility of the field being undefined.
Pull Request Test Coverage Report for Build 9461883835Details
💛 - Coveralls |
| it('should not allow an invalid type value', () => { | ||
| const zerionBalance = zerionBalanceBuilder().build(); | ||
| // @ts-expect-error - type is expected to be a 'positions' literal | ||
| zerionBalance.type = 'invalid'; |
There was a problem hiding this comment.
What do you think about adding an unknown literal here if it throws?
| chain_id: z.string(), | ||
| address: z.string().nullable(), | ||
| address: z.string().nullish().default(null), |
There was a problem hiding this comment.
We could use AddressSchema here (and add a test for checksumming).
| // @ts-expect-error - id is expected to be a string | ||
| zerionBalance.id = faker.number.int(); |
There was a problem hiding this comment.
I was initially going to suggest we move this into the builder but this is a much more future-proof method of overwriting the values that we should consider doing elsewhere in schema tests - if the type changes to match that expected, TypeScript will complain. (If we casted it inside the with of a builder, it wouldn't.)
There was a problem hiding this comment.
It makes perfect sense to me! 👍🏻
Pull Request Test Coverage Report for Build 9468416367Details
💛 - Coveralls |
Changes
ZerionBalancesentity schema unit tests.nullable()bynullish().default(null)for several fields in theZerionBalanceschema, following the Zerion API documentation.