Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize AccountsModule behind FF_ACCOUNTS #1656

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

AccountsDatasource was added in #1654

This PR initializes the class dependency chain (AccountsModule -> AccountsRepository -> AccountsDatasource) in AppModule, when FF_ACCOUNTS is enabled in the configuration.

Note: as a side effect of this change, /migrations/00001_accounts/index.sql will be applied if FF_ACCOUNTS is enabled.

Changes

  • Adds AccountsModule and AccountsRepository (along with its interface).
  • Imports AccountsDatasourceModule into AccountsRepositoryModule.

@hectorgomezv hectorgomezv self-assigned this Jun 14, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner June 14, 2024 18:06
@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9520451734

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 92.326%

Totals Coverage Status
Change from base Build 9518177005: 0.1%
Covered Lines: 6893
Relevant Lines: 7181

💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 5145868 into main Jun 17, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the initialize-accounts-datasource branch June 17, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants