Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executedSurplusFee to TwapOrders #1714

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

hectorgomezv
Copy link
Member

Changes

  • Adds executedSurplusFee to txInfo for TwapOrder items, as the sum of the executedSurplusFee values in the order parts.

@hectorgomezv hectorgomezv self-assigned this Jul 2, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner July 2, 2024 10:33
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9759395712

Details

  • 2 of 7 (28.57%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 48.567%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/entities/confirmation-view/confirmation-view.entity.ts 1 2 50.0%
src/routes/transactions/entities/swaps/twap-order-info.entity.ts 1 2 50.0%
src/routes/transactions/mappers/common/twap-order.mapper.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/mappers/common/twap-order.mapper.ts 1 26.14%
Totals Coverage Status
Change from base Build 9756880101: -0.03%
Covered Lines: 4213
Relevant Lines: 6997

💛 - Coveralls

@hectorgomezv hectorgomezv force-pushed the twaps/add-executed-surplus-fee branch from f2c4b1d to 048e2c7 Compare July 2, 2024 10:40
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9759371077

Details

  • 2 of 7 (28.57%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 48.567%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/entities/confirmation-view/confirmation-view.entity.ts 1 2 50.0%
src/routes/transactions/entities/swaps/twap-order-info.entity.ts 1 2 50.0%
src/routes/transactions/mappers/common/twap-order.mapper.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/mappers/common/twap-order.mapper.ts 1 26.14%
Totals Coverage Status
Change from base Build 9756880101: -0.03%
Covered Lines: 4213
Relevant Lines: 6997

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9759492375

Details

  • 2 of 7 (28.57%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 48.609%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/entities/confirmation-view/confirmation-view.entity.ts 1 2 50.0%
src/routes/transactions/entities/swaps/twap-order-info.entity.ts 1 2 50.0%
src/routes/transactions/mappers/common/twap-order.mapper.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/mappers/common/twap-order.mapper.ts 1 26.14%
Totals Coverage Status
Change from base Build 9756880101: 0.01%
Covered Lines: 4215
Relevant Lines: 6997

💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 7e16e2a into main Jul 2, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the twaps/add-executed-surplus-fee branch July 2, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants