Only log when trying to map restricted swap transfers #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorgomezv
reviewed
Jul 5, 2024
| `Unsupported App: ${order.fullAppData?.appCode}`, | ||
| ); | ||
| // Don't throw in order to fallback to "standard" transfer mapping | ||
| return null; |
There was a problem hiding this comment.
Nit: while I see null returns in many other places related to transactions/swap/twaps mappings to indicate a failure, I also think we should refactor the null returns and change them for actual errors and do proper error handling in the upper layers/caller functions, wdyt? (This is just a general comment, I'm totally fine with this PR 🙂)
There was a problem hiding this comment.
I agree. There is a common pattern with the finding then mapping of swap-related transactions that needs to be refactored in general. I think it would also solve this.
There was a problem hiding this comment.
"Proper error handling" has been included in #1733, but it should definitely be refactored as mentioned.
hectorgomezv
approved these changes
Jul 5, 2024
Pull Request Test Coverage Report for Build 9806877275Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When mapping a swap transfer, we are currently throwing if the transfer was created by a disallowed app. This means that the mapping breaks when we should be falling back to "standard" transfer mapping.
This switches from throwing to instead logging and returning
nullinstead of a mapped swap transfer. This means that the "standard" mapping will be done instead.Changes
nullinstead of throwing when mapping a disallowed swap transfer