-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(onramp-kit): Monerium integration #372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
dasanra
reviewed
May 8, 2023
dasanra
reviewed
May 8, 2023
dasanra
reviewed
May 8, 2023
dasanra
reviewed
May 8, 2023
dasanra
reviewed
May 8, 2023
dasanra
reviewed
May 10, 2023
Comment on lines
82
to
93
const isMessagePending = pendingTransactions.results.some((tx) => { | ||
if ( | ||
// @ts-expect-error - dataDecoded should have the method property | ||
tx?.dataDecoded?.method === 'signMessage' && | ||
// @ts-expect-error - dataDecoded should have the parameters array | ||
tx?.dataDecoded?.parameters[0]?.value === ethers.utils.hashMessage(message) | ||
) { | ||
return true | ||
} | ||
|
||
return false | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const isMessagePending = pendingTransactions.results.some((tx) => { | |
if ( | |
// @ts-expect-error - dataDecoded should have the method property | |
tx?.dataDecoded?.method === 'signMessage' && | |
// @ts-expect-error - dataDecoded should have the parameters array | |
tx?.dataDecoded?.parameters[0]?.value === ethers.utils.hashMessage(message) | |
) { | |
return true | |
} | |
return false | |
}) | |
const isMessagePending = pendingTransactions.results.some((tx) => ( | |
// @ts-expect-error - dataDecoded should have the method property | |
tx?.dataDecoded?.method === 'signMessage' && | |
// @ts-expect-error - dataDecoded should have the parameters array | |
tx?.dataDecoded?.parameters[0]?.value === ethers.utils.hashMessage(message) | |
)) |
dasanra
approved these changes
May 11, 2023
DaniSomoza
approved these changes
May 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #376
How this PR fixes it
We are creating a new pack allowing users to integrate the Safe with Monerium. An example integration can be explored here
We are implementing our common interface providing the following methods:
init(MoneriumPack)
- Allow to initialize the kit with theMoneriumPack
. We are going to provide the clientId and choose the Monerium environment to work with (sandbox or production)open(MoneriumOpenOptions)
- We are going to start the Monerium flow in 3 ways:subscribe(event, handler) / unsubscribe(event)
- Once authenticated this methods allow the user to establish a socket connection with the Monerium servers and listen for order status changesclose()
- To cleanup the connection with MoneriumHow to test it
Use Cases
Read integration notes and attached videos to check how the example behaves