Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(account-abstraction-kit): use the protocol kit #431

Merged
merged 1 commit into from
May 11, 2023
Merged

fix(account-abstraction-kit): use the protocol kit #431

merged 1 commit into from
May 11, 2023

Conversation

DaniSomoza
Copy link
Contributor

@DaniSomoza DaniSomoza commented May 11, 2023 •
edited

What it solves

Resolves:

  • fix the relayTransaction function in the account-abstraction-kit
  • fix the initialization of the account-abstraction-kit when the Safe is not deployed.

How this PR fixes it

Adding a instance of the protocol kit instead of using the Safe contract instance directly.

safe-core-sdk/packages/account-abstraction-kit/src/AccountAbstraction.ts

Lines 31 to 36 in 1671f01

class AccountAbstraction {
#ethAdapter: EthersAdapter
#signer: ethers.Signer
#safeSdk?: Safe
#safeProxyFactoryContract?: GnosisSafeProxyFactoryContract
#relayPack?: RelayPack

@DaniSomoza DaniSomoza merged commit 76c7a82 into development May 11, 2023
12 checks passed
@DaniSomoza DaniSomoza deleted the hotfix-aa-kit-poc branch May 11, 2023 16:10
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germartinez germartinez germartinez left review comments

@dasanra dasanra dasanra approved these changes

@yagopv yagopv Awaiting requested review from yagopv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DaniSomoza @germartinez @dasanra