Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default Safe version to 1.3.0 #484

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Set default Safe version to 1.3.0 #484

merged 2 commits into from
Jul 13, 2023

Conversation

germartinez
Copy link
Member

@germartinez germartinez commented Jul 13, 2023

The SDK supports the Safe Contracts v1.4.1, but because they are only deployed in a couple of networks, we will still have the v1.3.0 as default.

In case developers want to deploy v1.4.1 Safes, they will need to pass the safeVersion property with value 1.4.1 in the initialization of the SafeFactory class in the protocol-kit. Existing v1.4.1 Safes are compatible by default with no specific setups.

@coveralls
Copy link

coveralls commented Jul 13, 2023

Coverage Status

coverage: 74.968%. remained the same when pulling 94fcfb4 on default_1_3_0 into 499b80b on development.

@germartinez germartinez marked this pull request as ready for review July 13, 2023 11:52
@germartinez germartinez requested review from dasanra, yagopv and DaniSomoza and removed request for dasanra July 13, 2023 11:57
@germartinez germartinez merged commit 7c73018 into development Jul 13, 2023
15 checks passed
@germartinez germartinez deleted the default_1_3_0 branch July 13, 2023 12:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants