feat(protocol-kit): EIP-1271 integration #529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/validate-signatures
…obal/safe-core-sdk into feat/validate-signatures
dasanra
reviewed
Sep 26, 2023
jamiegreen7
approved these changes
Oct 8, 2023
| SafeSignature, | ||
| SafeTransaction, | ||
| SafeTransactionDataPartial, | ||
| SafeTransactionEIP712Args, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
yagopv
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #14
How this PR fixes it
We are adding the execution of the
isValidSignature(hash, signatures)to theSafeclassMore info:
What can we do with this new method
Safe implementation
Safe docs
Safe docs