Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix exception handling in signature decoding for Monerium Pack #599

Merged
merged 2 commits into from
Nov 22, 2023
Merged

fix exception handling in signature decoding for Monerium Pack #599

merged 2 commits into from
Nov 22, 2023

Conversation

DaniSomoza
Copy link
Contributor

What it solves

Improve exception handling in signature decoding for Monerium.pack

Added a couple of unit tests

How this PR fixes it

Now we are using Promise.allSettled instead of Promise.all
Added parseIsValidSignatureErrorResponse and decodeSignatureData to parse the error

dasanra
dasanra approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@dasanra dasanra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yagopv you should also review this piece of code when you have a moment

@dasanra dasanra requested a review from yagopv November 22, 2023 12:37
@DaniSomoza DaniSomoza merged commit 6e213c4 into release Nov 22, 2023
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
@DaniSomoza DaniSomoza linked an issue Nov 22, 2023 that may be closed by this pull request
Fix Monerium signature decoding on the Demo app #600
Closed
@dasanra dasanra deleted the fix-Monerium-signature-decode branch November 24, 2023 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dasanra dasanra dasanra approved these changes

@yagopv yagopv Awaiting requested review from yagopv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Monerium signature decoding on the Demo app
2 participants
@DaniSomoza @dasanra