Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-kit): Fix memoization issue across different chains in the predict Safe address util #640

Merged
merged 12 commits into from
Dec 19, 2023

Conversation

DaniSomoza
Copy link
Contributor

@DaniSomoza DaniSomoza commented Dec 15, 2023

What it solves

Resolves #598 & #634

Added the Sepolia chain to the protocol-kit tests.

Fixed Performance issue in the predictSafeAddress util function

How this PR fixes it

Added the chainId to the memoization cache to prevent issues across different chains.

current performance in development branch: ~ 4 addresses/second
current performance this fix-memoization-issue-predict-safe-address branch: ~ 4000 addresses/second

Example In development branch:

Grabacion.de.pantalla.2023-12-15.a.las.13.24.39.mov

Example In this fix-memoization-issue-predict-safe-address branch:

Grabacion.de.pantalla.2023-12-15.a.las.13.25.59.mov

@coveralls
Copy link

coveralls commented Dec 15, 2023

Pull Request Test Coverage Report for Build 7247247765

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-10.1%) to 75.0%

Totals Coverage Status
Change from base Build 7247224444: -10.1%
Covered Lines: 462
Relevant Lines: 570

💛 - Coveralls

@dasanra dasanra changed the base branch from main to development December 15, 2023 12:18
@dasanra dasanra changed the base branch from development to chore/remove-infura-key December 15, 2023 15:43
Base automatically changed from chore/remove-infura-key to development December 18, 2023 11:09
@DaniSomoza DaniSomoza merged commit 83162da into development Dec 19, 2023
14 of 15 checks passed
@DaniSomoza DaniSomoza deleted the fix-memoization-issue-predict-safe-address branch December 19, 2023 11:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

predictSafeAddress doesn't work when generating multiple wallets across different chains (memoization issue)
4 participants