Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove test INFURA_KEY #641

Merged
merged 5 commits into from
Dec 18, 2023
Merged

chore: Remove test INFURA_KEY #641

merged 5 commits into from
Dec 18, 2023

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Dec 15, 2023

What it solves

We are removing the INFURA_KEY in the protocol-kit and the api-kit.

We are using public RPC nodes instead of Infura.

We added Sepolia chain to our protocol-kit tests.

Advantages:

  • Removing dependencies and secrets
  • Allowing external PR's to execute tests as cannot access Github secrets for security reasons

@yagopv yagopv changed the base branch from main to development December 15, 2023 11:44
@coveralls
Copy link

coveralls commented Dec 15, 2023

Pull Request Test Coverage Report for Build 7246363597

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+18.6%) to 100.0%

Totals Coverage Status
Change from base Build 7222021252: 18.6%
Covered Lines: 25
Relevant Lines: 25

💛 - Coveralls

@dasanra dasanra merged commit 6eba59a into development Dec 18, 2023
14 of 15 checks passed
@dasanra dasanra deleted the chore/remove-infura-key branch December 18, 2023 11:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants