Add Neon Devnet deployments #214
Conversation
Sj-001
requested review from
rmeissner,
Uxio0,
mmv08,
moisses89 and
hectorgomezv
|
@Sj-001 must be necessary to create an issue to add new-chain and provide all the required information to review this PR. |
|
Hey @moisses89 , I tried to create the issue but I keep getting 500 server error. |
1 similar comment
|
Hey @moisses89 , I tried to create the issue but I keep getting 500 server error. |
|
Created. please check @moisses89 |
There was a problem hiding this comment.
We only accept deterministic addresses here.
To do that you should use the singleton factory to deploy the contracts, be careful to use the correct branch https://github.com/safe-global/safe-contracts#deploy
But first singleton factory should be deployed safe-global/safe-singleton-factory#112
| @@ -95,6 +95,7 @@ | |||
| "421611": "0xf48f2B2d2a534e402487b3ee7C18c33Aec0Fe5e4", | |||
| "421613": "0xf48f2B2d2a534e402487b3ee7C18c33Aec0Fe5e4", | |||
| "11155111": "0x017062a1dE2FE6b99BE3d9d37841FeD19F573804", | |||
| "245022926": "0xAb5209Fbd1512008836259Cdb317199ED57faA83", | |||
There was a problem hiding this comment.
This address is not the deterministic address
There was a problem hiding this comment.
hey @moisses89 , I deployed the safe-contracts again using 0x914d7fec6aac8cd542e72bca78b30650d45643d7 as the singleton factory deployed by @Uxio0 on Neon. Please review again.
There was a problem hiding this comment.
@Sj-001 which tag branch did you use on safe-contracts? you should use v1.3.0-libs.0 as is described here https://github.com/safe-global/safe-contracts#deploy
I'm asking because are not still the deterministic addresses.
There was a problem hiding this comment.
Gotcha, deployed again, please review, I think its the correct one now:) @moisses89
Sj-001
requested review from
moisses89
and removed request for
rmeissner,
Uxio0,
mmv08 and
hectorgomezv
Closes #215
RPC: https://devnet.neonevm.org