Optimize to_checksum_address function
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2508862086
💛 - Coveralls |
Uxio0
force-pushed
the
optimize-checksum-calculation
branch
from
4641772
to
c6b498a
Compare
|
Related to safe-global/safe-pm#89 |
mmv08
reviewed
Jun 16, 2022
Comment on lines
+46
to
+51
| norm_address[i].upper() | ||
| if int(address_hash[i], 16) > 7 | ||
| else norm_address[i] |
There was a problem hiding this comment.
I'd add a link to https://github.com/ethereum/EIPs/blob/master/EIPS/eip-55.md as a comment
Uxio0
force-pushed
the
optimize-checksum-calculation
branch
from
c6b498a
to
1578363
Compare
moisses89
reviewed
Jun 16, 2022
| @@ -888,9 +892,9 @@ def retrieve_fallback_handler( | |||
| self.address, | |||
| self.FALLBACK_HANDLER_STORAGE_SLOT, | |||
| block_identifier=block_identifier, | |||
| )[-20:] | |||
| )[-20:].rjust(20, b"\0") | |||
There was a problem hiding this comment.
Because get_storage ignores leading zeroes, I don't really know why
Uxio0
force-pushed
the
optimize-checksum-calculation
branch
2 times, most recently
from
061ded5
to
2ac4059
Compare
While developing Safe Tx Service we found out that a lot of time was spent on converting addresses from `bytes` to `ChecksumAddress`. Biggest part of this time was overhead added on `eth_utils` library to `keccak256` function. So we decided to use `pysha3` library (way faster than `pycryptodome`) directly. That's why we implemented new methods: - fast_keccak - fast_keccak_hex - fast_keccak_hex - fast_to_checksum_address - fast_bytes_to_checksum_address - fast_is_checksum_address This is also very relevant for the `EthereumAddressV2Field`, as it stores addresses as `bytes` on database and returns them as `ChecksumAddress` Related to: - ethereum/eth-utils#95 - ethereum/eth-hash#35
Uxio0
force-pushed
the
optimize-checksum-calculation
branch
from
2ac4059
to
c3f2f15
Compare
mmv08
approved these changes
Jun 16, 2022
moisses89
approved these changes
Jun 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing Safe Tx Service we found out that a lot of time was spent on converting addresses from
bytestoChecksumAddress. Biggest part of this time was overhead added oneth_utilslibrary tokeccak256function.So we decided to use
pysha3library (way faster thanpycryptodome) directly. That's why we implemented new methods:This is also very relevant for the
EthereumAddressV2Field, as it stores addresses asbyteson database and returns them asChecksumAddressRelated to: