Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update typography as per UI Kit #301

Merged
merged 24 commits into from
Jun 17, 2024
Merged

feat: update typography as per UI Kit #301

merged 24 commits into from
Jun 17, 2024

Conversation

DiogoSoaress
Copy link
Member

@DiogoSoaress DiogoSoaress commented Apr 10, 2024

Update theme's typography as per latest UI Kit guide -> https://www.figma.com/file/qtXXlwdslAze6yNbLLzIRa/Website-redesign-2.0?type=design&node-id=10829-708&mode=design&t=zuBY8bCFKL1ILz9H-0

Typography feedback was collected here: https://www.notion.so/safe-global/Typography-Updates-QA-54b63bdeab744e80a5605402a85e7753

I've addressed in #368 the feedback I found unrelated with this change

Copy link

github-actions bot commented Apr 10, 2024

Branch preview

✅ Deployed successfully in branch deployment:

https://update_typography--homepage.review.5afe.dev

Copy link

github-actions bot commented Apr 10, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented May 30, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@DiogoSoaress DiogoSoaress marked this pull request as ready for review May 30, 2024 13:21
@DiogoSoaress
Copy link
Member Author

@TanyaEfremova can you review the typography changes across the pages? The font change is very noticeable so I'd like to have your 👍 before merging it into production. Link -> https://update_typography--homepage.review.5afe.dev/

@TanyaEfremova
Copy link
Contributor

Some of the headings use font weight light (300), however, it was only intended for the body text.

@DiogoSoaress
Copy link
Member Author

Some of the headings use font weight light (300), however, it was only intended for the body text.

You're right! Just fixed it. Can you check again?

@DiogoSoaress DiogoSoaress merged commit 8e584e6 into main Jun 17, 2024
5 checks passed
@DiogoSoaress DiogoSoaress deleted the update-typography branch June 17, 2024 16:31
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants