Skip to content

Commit

Permalink
Add Typescript dependency to passkey package (#421)
Browse files Browse the repository at this point in the history
This PR adds missing `typescript` dependency to the `safe-passkey`
package which was causing build errors locally (maybe there is a global
Typescript installation on CI and on @mmv08's machine). Also, there was
some linting errors that weren't caught.

Also, PNPM reordered `package.json` for the passkey package, and I
manually did it for the other packages.
  • Loading branch information
nlordell committed May 16, 2024
1 parent f52ba62 commit 13d7d66
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 17 deletions.
2 changes: 1 addition & 1 deletion modules/4337/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@
"devDependencies": {
"@account-abstraction/contracts": "^0.7.0",
"@noble/curves": "^1.4.0",
"@nomicfoundation/hardhat-toolbox": "^5.0.0",
"@nomicfoundation/hardhat-ethers": "^3.0.6",
"@nomicfoundation/hardhat-network-helpers": "^1.0.10",
"@nomicfoundation/hardhat-toolbox": "^5.0.0",
"@openzeppelin/contracts": "^5.0.2",
"@safe-global/safe-4337-local-bundler": "workspace:^0.0.0",
"@safe-global/safe-4337-provider": "workspace:^0.0.0",
Expand Down
7 changes: 4 additions & 3 deletions modules/passkey/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@
},
"devDependencies": {
"@noble/curves": "^1.4.0",
"@nomicfoundation/hardhat-toolbox": "^5.0.0",
"@nomicfoundation/hardhat-ethers": "^3.0.6",
"@nomicfoundation/hardhat-network-helpers": "^1.0.10",
"@nomicfoundation/hardhat-toolbox": "^5.0.0",
"@safe-global/mock-contract": "^4.1.0",
"@safe-global/safe-4337": "workspace:^0.3.0",
"@safe-global/safe-4337-local-bundler": "workspace:^0.0.0",
Expand All @@ -58,11 +58,12 @@
"ethers": "^6.12.1",
"hardhat": "^2.22.3",
"hardhat-deploy": "^0.12.4",
"solhint": "^5.0.1"
"solhint": "^5.0.1",
"typescript": "^5.4.5"
},
"dependencies": {
"@openzeppelin/contracts": "^5.0.0",
"@account-abstraction/contracts": "^0.7.0",
"@openzeppelin/contracts": "^5.0.0",
"@safe-global/safe-contracts": "^1.4.1-build.0",
"cbor": "^9.0.2"
}
Expand Down
10 changes: 5 additions & 5 deletions packages/4337-local-bundler/hardhat.config.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import "@nomicfoundation/hardhat-toolbox"
import {HardhatUserConfig} from 'hardhat/types'
import '@nomicfoundation/hardhat-toolbox'
import { HardhatUserConfig } from 'hardhat/types'

const config: HardhatUserConfig = {
solidity: "0.8.24",
};
solidity: '0.8.24',
}

export default config;
export default config
5 changes: 3 additions & 2 deletions packages/4337-local-bundler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,17 @@
"scripts": {
"build": "rimraf dist && tsc && chmod +x dist/src/bin/*.js",
"lint": "eslint .",
"lint:fix": "eslint . --fix",
"prepare": "pnpm run build"
},
"dependencies": {
"@safe-global/safe-contracts" : "^1.4.1-build.0",
"@account-abstraction/contracts": "^0.7.0",
"@nomicfoundation/hardhat-toolbox": "^5.0.0",
"@safe-global/safe-4337-provider": "workspace:^0.0.0",
"@safe-global/safe-contracts" : "^1.4.1-build.0",
"ethers": "^6.12.1",
"hardhat": "^2.22.3",
"hardhat-deploy": "^0.12.4",
"ethers": "^6.12.1",
"node-fetch": "^3.3.2",
"typescript": "^5.4.5"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/4337-provider/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
},
"dependencies": {
"@types/node": "^20.12.11",
"rimraf" :"^5.0.7",
"ethers": "^6.12.1",
"rimraf" :"^5.0.7",
"typescript": "^5.4.5"
}
}
Loading

0 comments on commit 13d7d66

Please sign in to comment.