Add Typescript dependency to passkey package #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
|
@mmv08 - this merges into your PR. |
mmv08
approved these changes
May 16, 2024
nlordell
force-pushed
the
420-small-changes
branch
from
9f02aa7
to
cb397ee
Compare
Pull Request Test Coverage Report for Build 9112898750Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing
typescriptdependency to thesafe-passkeypackage which was causing build errors locally (maybe there is a global Typescript installation on CI and on @mmv08's machine). Also, there was some linting errors that weren't caught.Also, PNPM reordered
package.jsonfor the passkey package, and I manually did it for the other packages.