Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 4337-gas-metering/alchemy to use v0.7 EntryPoint #316

Closed
remedcu opened this issue Mar 11, 2024 · 1 comment
Closed

Update 4337-gas-metering/alchemy to use v0.7 EntryPoint #316

remedcu opened this issue Mar 11, 2024 · 1 comment
Assignees
@mmv08

Comments

@remedcu
Copy link
Member

remedcu commented Mar 11, 2024

The current version uses v0.6 EntryPoint for gas metering, as the latest version is released, it is best to use the latest version for the Gas Analysis.

Current Blockers:

  • Alchemy does not support EntryPoint v0.7 currently.

Expected Outcome

  • Using v0.7 EntryPoint with the compatible Safe 4337 Module.
  • Table containing gas usage for Alchemy with Safe 4337 Module.
@remedcu
Copy link
Member Author

remedcu commented Mar 18, 2024

To Check Support: https://docs.alchemy.com/reference/eth-supportedentrypoints

@remedcu remedcu mentioned this issue Mar 19, 2024
Merged
remedcu added a commit that referenced this issue Mar 19, 2024
@remedcu
Improving the type definition of SAFE_ADDRESS_MAP (#333)
e0738cd 
This PR just improves the `type` definition of `SAFE_ADDRESS_MAP` to
remove some of the linting errors.

P.S. `userOps` linting errors will be solved with either #294 or #316.
@nlordell nlordell mentioned this issue Apr 3, 2024
Closed
@mmv08 mmv08 self-assigned this Jul 15, 2024
@mmv08 mmv08 mentioned this issue Jul 18, 2024
Merged
mmv08 added a commit that referenced this issue Jul 19, 2024
@mmv08
4337 Benchmark: Alchemy with EntryPoint 0.7.0 (#466)
f84200f 
This PR partially #316:
1. It upgrades Alchemy code to use the v0.7.0 of the entrypoint,
including all the alchemy-related packages
2. I exported all the alchemy-related utils function from
`src/utils/userOps.ts` to `alchemy/utils.ts`
3. I also added a special exception for the case where the user
operations do not involve account deployment where if the account
doesn't have enough stake in the entrypoint from the previous deployment
user operation, it will execute a call to `depositTo` in the entry point
and inflate the benchmark numbers. Now, a special case is added with the
entrypoint deposit before the user operation submission for all user
operations that do not involve a deployment.
@mmv08 mmv08 closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmv08 mmv08

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmv08 @remedcu