Emit Event on Shared Signer Configuration #456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hats-finance#3
This PR adds an event that is emitted on shared signer configuration. Note that the event is emitted in the context of the configured Safe account. In order to prevent event
topic0
collisions, we chose an explicitly verbose name.With respect to indexing, we explicitly chose not to index any of the fields so that it matches the
Created
event:safe-modules/modules/passkey/contracts/interfaces/ISafeSignerFactory.sol
Lines 13 to 20 in bb5e1f7
To re-iterate on the reasons we chose to not index some of the fields (same reasoning applies to
Created
event above):x
andy
: These are single-use public key coordinates attached to a passkey. It doesn't make sense to filter events by "all events withx
value", or similarly "all events withy
value". Furthermore, you can compute thesigner
(which is indexed in theCreated
event) from the key coordinates, so you can to some degree search for signers for a given key coordinate.verifiers
: This felt more like a configuration than something that Dapps would need to filter by. Why it might be interesting to see on chain which verifiers are being used, tools like Dune can help with this, and the additional cost of an indexed field is not worth it in our opinion.