Feature: enforce dataHash to be a hash of data, minor test enhancements

[mmv08]

This PR:

• Implements Enforce that dataHash is the hash of data #497
  • To test the issue properly, I had to create a new function buildContractSignature and adjust buildSignatureBytes to support contract signatures with the dynamic part to avoid creating contract signatures in a raw manner
• Improves tests for mixing all signature types with smart contract signatures by using newly created/adjusted functions from above. The tests were in fact incomplete because they were missing smart contract signature type

[coveralls]

Pull Request Test Coverage Report for Build 3998833487

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-1.5%) to 97.04%

---

Totals
Change from base Build 3947530336:	-1.5%
Covered Lines:	305
Relevant Lines:	313

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 3998833487

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.009%) to 98.52%

---

Totals
Change from base Build 3947530336:	0.009%
Covered Lines:	312
Relevant Lines:	313

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 4007838837

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.009%) to 98.52%

---

Totals
Change from base Build 3947530336:	0.009%
Covered Lines:	312
Relevant Lines:	313

---

💛 - Coveralls

[Uxio0]

Could you add more information in the PR about the "test enhancements" and the reasoning? They don't see very clear to me. Also maybe some comments in buildSignatureBytes will make us easier to understand in the future what's going on

[mmv08]

Could you add more information in the PR about the "test enhancements" and the reasoning? They don't see very clear to me. Also maybe some comments in buildSignatureBytes will make us easier to understand in the future what's going on

updated the code and description, could you please recheck?

[Uxio0]

Thanks for updating it @mikhailxyz , it makes sense now. Then after merging this we should close or refactor #416